Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture stack traces from spec frame #4932

Closed
chrisbreiding opened this issue Aug 5, 2019 · 3 comments
Closed

Capture stack traces from spec frame #4932

chrisbreiding opened this issue Aug 5, 2019 · 3 comments
Assignees
Labels
type: duplicate This issue or pull request already exists

Comments

@chrisbreiding
Copy link
Contributor

It's currently not possible to capture stack traces from the spec frame because cy is defined in the top frame and browser don't allow cross-frame stack traces to be captured. In order to achieve this, we need to:

  • Wrap the spec & support file, so code can be injected into them
    • This will also allow passing in information about the spec (i.e. its file path) that's otherwise inaccessible
  • Define the cy object in the spec file and proxy it up to the top frame. Stack traces can be captured within the spec frame and then passed up into the top frame
@chrisbreiding chrisbreiding added type: enhancement Requested enhancement of existing feature pkg/driver This is due to an issue in the packages/driver directory labels Aug 5, 2019
@chrisbreiding chrisbreiding self-assigned this Aug 5, 2019
@jennifer-shehane
Copy link
Member

@chrisbreiding Is this related to this issue? #881

@chrisbreiding
Copy link
Contributor Author

#881 is more related to #3966. This issue is tracking a blocker for that.

I thought this work would be somewhat involved and necessitate some structural changes, so I created this issue. However, it currently seems that it won't end up being significant enough for its own issue, so I'll probably close this issue and the work will just done as a part of #3966.

@chrisbreiding
Copy link
Contributor Author

Closing because this ended up not being enough work to require its own issue and PR outside of #3966.

@cypress-io cypress-io locked and limited conversation to collaborators Jan 6, 2020
@jennifer-shehane jennifer-shehane added type: duplicate This issue or pull request already exists and removed stage: work in progress pkg/driver This is due to an issue in the packages/driver directory type: enhancement Requested enhancement of existing feature labels Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants