Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout issues with desktop GUI in 3.4.1 #4888

Closed
chrisbreiding opened this issue Jul 31, 2019 · 5 comments · Fixed by #4905
Closed

Layout issues with desktop GUI in 3.4.1 #4888

chrisbreiding opened this issue Jul 31, 2019 · 5 comments · Fixed by #4905
Assignees
@chrisbreiding
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: regression A bug that didn't appear until a specific Cy version release type: user experience Improvements needed for UX

Comments

@chrisbreiding
Copy link
Contributor

chrisbreiding commented Jul 31, 2019 •
edited
Loading

Current behavior:

Moving to flexbox for the desktop GUI has created some layout problems.

When loading, the footer appears at the top:

Screen Shot 2019-07-31 at 10 26 39 AM

When there is a long list of specs and the update banner is present, the bottom of the list is cut off and it's impossible to scroll to the last spec:

Screen Shot 2019-07-31 at 10 26 46 AM

Desired behavior:

Layout should be the same as previous versions.

Versions

Cypress: 3.4.1
OS: MacOS
Browser: N/A
@chrisbreiding chrisbreiding self-assigned this Jul 31, 2019
@chrisbreiding chrisbreiding added pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: regression A bug that didn't appear until a specific Cy version release type: user experience Improvements needed for UX labels Jul 31, 2019
@chrisbreiding chrisbreiding mentioned this issue Aug 1, 2019
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Aug 1, 2019
@brian-mann
Copy link
Member

Can you post screenshots of the after fix?

@brian-mann
Copy link
Member

Good use case for screenshot diff'ing.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Aug 1, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 1, 2019

The code for this is done in cypress-io/cypress#4905, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@chrisbreiding
Copy link
Contributor Author

After screenshots:

Screen Shot 2019-08-02 at 9 05 33 AM
Screen Shot 2019-08-02 at 9 05 49 AM

@jennifer-shehane jennifer-shehane mentioned this issue Aug 14, 2019
Closed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrisbreiding chrisbreiding

Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: regression A bug that didn't appear until a specific Cy version release type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Desktop GUI layout issues/improvements cypress-io/cypress
2 participants
@chrisbreiding @brian-mann