Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update driver error structure so templates can be used #3688

Closed
4 tasks
lilaconlee opened this issue Mar 11, 2019 · 2 comments
Closed
4 tasks

Update driver error structure so templates can be used #3688

lilaconlee opened this issue Mar 11, 2019 · 2 comments
Assignees
@jennifer-shehane
Labels
type: chore Work is required w/ no deliverable to end user

Comments

@lilaconlee
Copy link
Contributor

lilaconlee commented Mar 11, 2019 •
edited
Loading

New error structures are required for the templates that'll be used to render different types of errors in the GUI. These changes will be made in the driver as part of this PR and leveraged by the reporter in a different PR.

The plan is to tackle one of each error type separately, then move onto the next.

Templates:

  • CypressError (single code frame)
  • CypressError (multiple code frames)
  • AssertionError
  • Spec/App Error
@lilaconlee lilaconlee self-assigned this Mar 11, 2019
@jennifer-shehane jennifer-shehane added the type: chore Work is required w/ no deliverable to end user label Mar 13, 2019
@lilaconlee lilaconlee mentioned this issue Mar 20, 2019
Merged
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 29, 2019

The code for this is done in cypress-io/cypress#3752, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane
Copy link
Member

This was completed as part of #6724 and released in 4.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennifer-shehane jennifer-shehane

Labels
type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jennifer-shehane @lilaconlee