Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more user-friendly when checking that baseUrl server is responding #3284

Closed
bahmutov opened this issue Feb 1, 2019 · 6 comments · Fixed by #5325
Closed

Be more user-friendly when checking that baseUrl server is responding #3284

bahmutov opened this issue Feb 1, 2019 · 6 comments · Fixed by #5325
Labels
good first issue Good for newcomers pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: user experience Improvements needed for UX

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Feb 1, 2019

Cypress 3.1.5

Currently, we only check if the server defined in baseUrl is responding when we start Cypress. If the user starts their server AFTER Cypress the message is very confusing and scary - and wrong

screen shot 2019-02-01 at 12 09 55 pm

It would be nicer to (a few alternatives)

  • retry the server periodically and remove the error message when the server responds
  • have a Retry button to test again. If the server responds, remove the message
  • at least add to the message text like "If you have started the server after Cypress, ignore this error"
@bahmutov bahmutov added the type: user experience Improvements needed for UX label Feb 1, 2019
@EmmanuelDemey
Copy link

I think the retry button is the most normal behaviour. As the refresh button when executing the test suite.

@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Feb 20, 2019
@jennifer-shehane jennifer-shehane added difficulty: 1️⃣ pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory good first issue Good for newcomers labels Feb 20, 2019
@must-git-good
Copy link

@jennifer-shehane

Does this still need work? I'd love to try smoothing out that experience, if so...

@jennifer-shehane
Copy link
Member

@must-git-good yes we would love an open PR - even one that is a work in progress is fine. Check out our contributing doc and ask us if you get stuck.

@nhc
Copy link

nhc commented Sep 24, 2019

@jennifer-shehane Does this still need looking at ?

@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Oct 9, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Oct 16, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Dec 23, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Feb 18, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Feb 27, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 27, 2020

The code for this is done in cypress-io/cypress#5325, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 28, 2020

Released in 4.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: user experience Improvements needed for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants