Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show diffs for assertions logged in browser console #3129

Open
1 of 3 tasks
kuceb opened this issue Jan 14, 2019 · 5 comments
Open
1 of 3 tasks

Show diffs for assertions logged in browser console #3129

kuceb opened this issue Jan 14, 2019 · 5 comments
Labels
pkg/driver This is due to an issue in the packages/driver directory type: feature New feature that does not currently exist type: user experience Improvements needed for UX
Milestone
Sprint 20

Comments

@kuceb
Copy link
Contributor

kuceb commented Jan 14, 2019 •
edited
Loading

Add diffs to assertion errors in cypress open mode

Current:

19-01-14_11 55 28

Desired:

image

In run mode, we already have diffs:

image

nice-to-haves:

  • collapse-able log block in console
  • show inline diff for long strings
  • use background color to show exactly what is different in each line (possible add this to the cypress run reporter
@kuceb kuceb self-assigned this Jan 14, 2019
@kuceb kuceb added the type: user experience Improvements needed for UX label Jan 14, 2019
@kuceb kuceb mentioned this issue Jan 14, 2019
Closed
3 tasks
@kuceb kuceb changed the title Show diff in console for assertions in open mode Show diffs for assertions logged in browser console Jan 14, 2019
@bahmutov
Copy link
Contributor

nice, this would be great for user experience

@jennifer-shehane jennifer-shehane added stage: needs review The PR code is done & tested, needs review pkg/driver This is due to an issue in the packages/driver directory labels Jan 15, 2019
@jennifer-shehane jennifer-shehane added this to the Sprint 20 milestone Jan 22, 2019
@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope and removed stage: needs review The PR code is done & tested, needs review labels Mar 13, 2019
@jennifer-shehane jennifer-shehane mentioned this issue Mar 21, 2019
Closed
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope labels Jun 11, 2019
@chrisbreiding chrisbreiding mentioned this issue May 1, 2020
Open
3 tasks
@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope and removed stage: needs review The PR code is done & tested, needs review labels Jul 13, 2020
@TheKnightCoder
Copy link

Has this been added to cypress yet? Would love this feature

@jennifer-shehane
Copy link
Member

@TheKnightCoder No, the issue will be closed when it is in the product.

@gurudattgd04
Copy link

@jennifer-shehane Any updates on this or any timeline for this ? This would make life easy for most of us

@gurudattgd04 gurudattgd04 mentioned this issue Feb 26, 2022
Open
@cypress-bot cypress-bot bot added stage: backlog and removed stage: ready for work The issue is reproducible and in scope labels Apr 29, 2022
@jpierson-at-riis
Copy link

I would recommend the visual diff feature showed off by https://github.com/benjamine/jsondiffpatch. If possible I think it would be really great to embed the visual diff feature by default for deep equality failures.

@jennifer-shehane jennifer-shehane added the type: feature New feature that does not currently exist label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg/driver This is due to an issue in the packages/driver directory type: feature New feature that does not currently exist type: user experience Improvements needed for UX
Projects
None yet
Milestone
Sprint 20
Development

Successfully merging a pull request may close this issue.

add diffs to assertions logged in browser console cypress-io/cypress
6 participants
@jennifer-shehane @bahmutov @gurudattgd04 @kuceb @TheKnightCoder @jpierson-at-riis