-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need tab support #299
Comments
I'd like to hear more about what you are looking to cover in terms of accessibility testing. Can you give me an example of a use case you are trying to test with the tab key? Right now there is not a way to press "tab". Currently we simulate all events in Cypress - although we automatically backfill in the browser's default behavior on all actions, which means that your application does what it does identically to native events. The problem with The solution for us is to enable native events within Cypress. We can "opt into" native events whenever we want, the problem is mostly with the UX experience around the debugger protocol. Namely that you cannot have Dev Tools open and issue native events due to the limitation of Chrome's debugger protocol. There is an open issue in Chromium to add multiplexing support so we've been waiting for that to go live. Until then we will kick the can, or eventually be forced into creating a good UX experience that either automatically closes Dev Tools, or prompts the user that their tests cannot continue until it is closed. |
thanks for the response The tab key is one of the primary ways a keyboard user moves around the page so it's difficult to write a high confidence accessibility test without it. In my case I'm building custom components that comply with the aria authoring practices guide. The first thing I would like to do on every page is press tab to focus the element. I can fake this by calling click() but it's not really the same. A non-sighted user will never use the mouse so calling click() feels a bit like cheating and you could imagine a situation where an element has one behavior when clicked and a different behavior when focused via the tab key. |
If you're testing the behavior of an element coming into focus, or you're testing things like styles you can just focus the element directly. cy.get("input").focus() What this doesn't test for is what the browser's behavior when clicking "tab". But you can often indirectly test this. For instance, you could just make sure that the element it's supposed to focus on has |
Yeah that's what I've been doing. Still, I would prefer |
I have a different use case for This is obviously distinct from accessibility use cases (as described above). Any update on |
In Chrome 63, there is support for multiplexing and we can now better handle native events. See #311 |
@jennifer-shehane Is this on the road map to be implemented? Or should we not expect this any time soon? |
I'd love to know as well. Just ran into this issue while writing a form validation test. |
Me too . I was expecting some way to tab to the next field like .type({tab}) |
Same as the above. I'm testing an app that mimics desktop application and heavily relies on keyboard usage. |
Has anyone found a good workaround for this? It seems as if we're not getting a tab function.. |
This seems to work: Cypress.Commands.add('typeTab', (shiftKey, ctrlKey) => {
cy.focused().then(($el) => {
cy.wrap($el).trigger('keydown', {
keyCode: 9,
which: 9,
shiftKey: shiftKey,
ctrlKey: ctrlKey
});
});
}); |
@scottschafer that fires the event, but the browser will not perform the default action such as moving the tab focus to the next focusable element |
@scottschafer This should be able to be simplified to this: Cypress.Commands.add('typeTab', (shiftKey, ctrlKey) => {
cy.focused().trigger('keydown', {
keyCode: 9,
which: 9,
shiftKey: shiftKey,
ctrlKey: ctrlKey
});
}); |
@brian-mann , ah. In our web app we specifically handle keyboard events and change focus programmatically. It works for us - sorry this won't work for you. |
@scottschafer Yes, glad to see you got this work in your use case. It should help anyone else that programmatically works off of the user's specific |
Whaaat? Tabbing was literally the first thing I tried testing 😄 Wanted to test the login form and the fact that pressing Tab on the password form doesn't focus the Show/hide password button but the Login button...
Wouldn't it be possible to allow users to customize the "algorithm" for tabbing? Figuring out where the focus will go is indeed a tricky problem, but for a majority of usecases it should work pretty straightforward. Figure out what is the next focusable element in the DOM after the current There are a few very good libs which also try to figure out which elements are focusable in order to trap focus in a modal or a dropdown. Maybe it's a good starting point to figure out what kind of algorithm they use to intercept focus leaving the modal and taking it back to the first focusable element in it? |
I think the key is to find or come up with an implementation that works for your use case. It's hard to come up with a general solution. FWIW, here's my implementation roughly based off of some of jQuery UI's logic: https://github.com/getstreamline/menu/blob/master/cypress/support/index.js#L39 One of the gotchas is that the It's naive but works for my use case! |
@decafdennis your tabbing stuff works well for me, thanks! The solution @jennifer-shehane posted wasn't working with the "shiftKey" variable for some reason. Tabbed forward but not backward. |
This comment has been minimized.
This comment has been minimized.
https://github.com/microsoft/playwright is already here and supports any keys 👍 |
What is the threshold for getting this in? Literally has more thumbs up than people watching this repo 😂 |
This likely isn't getting implemented. Some decisions made at a fundamental level put it in the "too hard" basket. Thus as mentioned above, the real solution is everyone switching to new tooling which doesn't suffer the same design flaw. |
Sad that it is taking years to get recognition that USERS use the tab key to navigate web pages. Sad. |
Just use |
This would be a great feature and I don't know why it's not already supported for tabbing between elements. It is required a great deal in most web based workflows. |
just FYI for those who are testing in firefox. |
How many more thumb ups do we need? |
@walleyyang could very well be that the way Cypress works does not allow an easy implementation of this. How many more times people need to tell you to use Playwright instead? 😆 |
No. It does not work great. |
Is there any update on this feature request? |
Will Cypress's new paid accessibility product cover tab navigation of forms and other interactable elements? https://www.cypress.io/blog/2024/02/16/introducing-cypress-accessibility |
Wow, is this still going on? May I suggest everyone do the correct thing... cough Playwright cough |
From my read that just checks tags and things exist. Some kind of basic checklist, surely not worth paying for. While Cypress itself will continue being incapable of actually testing the types of interactions needed to confirm accessibility. Well the website for the underlying service certainly has the "Use enough contrast as to be painful to look at" part down ;D |
I'm gonna add another vote "pro" multiple tabs feature. I got a case where all pages open in new tabs by clicking on respective buttons. The buttons don't have "target" attr or anything like that which would allow me to manipulate the DOM. And changing the whole system behavior based on one guy's request (who's just a QA and not an end-user) is absurd and nobody will do that, as the organization is huge. Nobody is gonna change the tool as it's already deeply rooted into the system architecture. I hope it will be added someday. |
@alexzavg This issue is in relation to Cypress not having support for simulating a press of the TAB key. It sounds like your comment may be for something related to multiple browser tabs? |
I stumbled over this feature today and can't believe, that Cypress does not support the +1 for adding |
oh, yeah, sorry about that, I was referring to the multiple tabs feature which is also something of importance. I guess I've misunderstood the thread title. |
+1 for adding {tab} to this list: https://docs.cypress.io/api/commands/type#Arguments. Is there any timeline? |
It's not that list. It's that you can't test pressing tab to navigate between fields. Thus can't test accessibility. It will never be implemented. We're all just hanging out here for the laughs. |
The laughs is the only way to play right! |
How can this never have been implemented before? Any news? |
It is the way Cypress interacts with your application. It runs in the same JavaScript context your application does. It is largely what made Cypress so great to work with in the first place. It was before there was a debug protocol to work with. All interactions are simulated. The events fired are not trusted events. For example, a The browser does not have a focus management API, meaning there is no way to tell the browser "focus on the next focusable element" The As for if you should be testing what the tab key does... You will get a different result in each browser and operating system. There are edge cases of specifications that have no defined behavior. For example, what should the enter key do on a In my cases, I use |
Description
As mentioned here https://docs.cypress.io/v1.0/docs/type#section-typing-tab-key-does-not-work. For accessibility testing I need to be able to tell the keyboard to press tab. If
cy.tab
is not currently supported is there some way to work around this?The text was updated successfully, but these errors were encountered: