Remove "Timed out retrying after **ms" from test error messages when command timeout is set to zero

[juan-belmonte]

What would you like?

I'd like that Cypress outputs a retry-agnostic error message when retries are disabled by setting defaultCommandTimeout to 0 — or any other scoped timeout-related setting to disable retries.

Having a conditional error message to display the "Timed out retrying after ***ms" prefix only when retries are in place:

• If retries are in place: Timed out retrying after ***ms: expected [...]
• Otherwise: expected [...]

Why is this needed?

Considering we use Cypress to implement end-to-end tests of our REST API, it's confusing for stakeholders to read timeout-related messages.
API responses are not expected to change, thus the defaultCommandTimeout: 0 setting.

Other

No response

[emilyrohrbough]

@juan-belmonte This error is created here:

cypress/packages/driver/src/cy/retries.ts

Lines 77 to 79 in 55e4898

	const prependMsg = error?.retry === false ? '' : errByPath('miscellaneous.retry_timed_out', {
	ms: options._runnableTimeout,
	}).message

A simple check to verify the options._runnableTimeout is greater than 0 would satisfy this request. Interested in a contribution?

[juan-belmonte]

Hi @emilyrohrbough. I'm more than interested, yes.

As you mentioned, the change is quite easy, but I struggle to find the existing test suite covering the driver's retries.ts code. Could you point me in the right direction, please?