Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numTestsKeptInMemory wrongly blamed for crash with cypress run in CI #28578

Open
nealeu opened this issue Dec 22, 2023 · 1 comment
Open

numTestsKeptInMemory wrongly blamed for crash with cypress run in CI #28578

nealeu opened this issue Dec 22, 2023 · 1 comment
Labels
type: enhancement Requested enhancement of existing feature type: error message

Comments

@nealeu
Copy link

nealeu commented Dec 22, 2023

Current behavior

The output generated on a crash as in this image is misleading users. The line referencing numTestsKeptInMemory should not appear when it is ignored for cypress run, and could also be intelligent about whether that value is actually greater than zero.

image

Desired behavior

No response

Test code to reproduce

This does not need reproducing.

Cypress Version

13.6.1

Node version

v18.14.2

Operating System

Ubuntu 22.04

Debug Logs

No response

Other

No response

@jennifer-shehane
Copy link
Member

@nealeu You can open a pull request to update it. It was a lot simpler at the time to have the text alone to explain the conditions it works than to connect all the logic to know which mode it’s running under.

@jennifer-shehane jennifer-shehane added type: enhancement Requested enhancement of existing feature type: error message labels Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Requested enhancement of existing feature type: error message
Projects
None yet
Development

No branches or pull requests

2 participants