-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Electron to 3.x.x, including related dependencies to match those in 3.x.x #2559
Comments
This would posible solve the issues with alpine Linux |
On which version of cypress this change will be available ? |
This is planned to be released in version 4.0 |
Might be worth considering Electron 4.0 now: https://electronjs.org/blog/electron-4-0 |
This is a real blocker for us since we're using RegExp lookbehind assertions, which were implemented in Chrome 62: https://www.chromestatus.com/feature/5668726032564224 Via Electron 1.8.2 cypress currently uses Chromium 59, where those regexes are just resulting in a syntax error. |
I have recently started running into the below issue intermittently, likely the result of an expanding codebase. I found that cypress/browsers:chrome69 image instead of the cypress/base:10 made the issue go away. This means that there are latent issues with an aging version of electron that are probably the cause of other issues, but workarounds to those issues are being entertained instead of keeping dependencies up to date. So for now I'm happy, I just don't get video recordings anymore. |
Closing in favor of upgrading to Electron 4.x. |
Current behavior:
Latest Cypress is still on Electron 1.8.2, which is two major versions behind latest stable release of 3.0.2.
Desired behavior:
Upgrading to Electron 3.0.2 will also bring in:
as related dependencies.
The text was updated successfully, but these errors were encountered: