Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Electron to 3.x.x, including related dependencies to match those in 3.x.x #2559

Closed
Jaemu opened this issue Oct 3, 2018 · 8 comments
Assignees
Labels
type: duplicate This issue or pull request already exists

Comments

@Jaemu
Copy link

Jaemu commented Oct 3, 2018

Current behavior:

Latest Cypress is still on Electron 1.8.2, which is two major versions behind latest stable release of 3.0.2.

Desired behavior:

Upgrading to Electron 3.0.2 will also bring in:

  • Node 10
  • Chromium 67
    as related dependencies.
@Jaemu
Copy link
Author

Jaemu commented Oct 3, 2018

This issue replaces #2253 as upgrading Node will be required as part of this work.

Not sure if #1659 would be entirely replaced by this change, might be worthwhile having a compatible version of Cypress for each of the electron major versions.

@jennifer-shehane jennifer-shehane added the type: chore Work is required w/ no deliverable to end user label Oct 3, 2018
@jennifer-shehane jennifer-shehane changed the title Upgrade Electron to 3.0.2, including related dependencies to match those in 3.0.2 Upgrade Electron to 3.x.x, including related dependencies to match those in 3.x.x Nov 2, 2018
@Ricky-rick
Copy link

This would posible solve the issues with alpine Linux
#419
electron/electron#2727 (comment)

@EmmanuelDemey
Copy link

On which version of cypress this change will be available ?

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Dec 10, 2018

This is planned to be released in version 4.0

@jraoult
Copy link

jraoult commented Jan 4, 2019

Might be worth considering Electron 4.0 now: https://electronjs.org/blog/electron-4-0

@jennifer-shehane jennifer-shehane added the stage: ready for work The issue is reproducible and in scope label Jan 15, 2019
@chrisbreiding chrisbreiding modified the milestones: Sprint 19, Sprint 20 Jan 22, 2019
@kommen
Copy link

kommen commented Jan 24, 2019

This is a real blocker for us since we're using RegExp lookbehind assertions, which were implemented in Chrome 62: https://www.chromestatus.com/feature/5668726032564224

Via Electron 1.8.2 cypress currently uses Chromium 59, where those regexes are just resulting in a syntax error.

@jpike88
Copy link

jpike88 commented Feb 16, 2019

I have recently started running into the below issue intermittently, likely the result of an expanding codebase.

#349

I found that cypress/browsers:chrome69 image instead of the cypress/base:10 made the issue go away. This means that there are latent issues with an aging version of electron that are probably the cause of other issues, but workarounds to those issues are being entertained instead of keeping dependencies up to date. So for now I'm happy, I just don't get video recordings anymore.

@jennifer-shehane jennifer-shehane removed this from the Sprint 21 milestone Feb 21, 2019
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Feb 22, 2019
@chrisbreiding
Copy link
Contributor

Closing in favor of upgrading to Electron 4.x.

@jennifer-shehane jennifer-shehane added type: duplicate This issue or pull request already exists and removed difficulty: 2️⃣ type: chore Work is required w/ no deliverable to end user labels Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

8 participants