-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video recorded is incomplete - last frames before tests are complete are not recorded #2370
Comments
This isn't a bug - we're really talking about maybe just a couple frames here. It is in fact recording everything, but the test runner UI uses react, which renders asynchronously (and the browser itself paints asynchronously) and therefore there's no guarantee that those frames are ever actually rendered before the browser itself shuts down. The test itself has already passed and therefore the browser is killed. Closing as not a bug. For this to "show" up we would have to artificially extend the run by a couple seconds which seems unnecessary considering there isn't really any useful information in the last couple frames. Had you run more tests the video would have covered all of them. |
I have similar issue, but it only happens in Linux, not for Mac. Actually it is not only incomplete, but also intermittent. You can see the video runs fine in first 3 to 5 seconds, then the video stay there for about 10 seconds, in the end of the video you might see one second view of moment of next steps. Videos becomes useless if they are always like this. But it works very well in Mac. Does anyone has same issue? By the way, we use |
I'm having a similar issue as well but on Mac. |
I've seen this issue crop up more recently. It does not generally look to be a couple of frames, but swaths of the video freeze during the video. |
In our case is just a matter of last frames. Currently we have only one test. We are using cypress 3.2.0 + docker cypress/base:8. An example incomplete video: https://47779-7910045-gh.circle-artifacts.com/0/root/project/cypress/videos/main-page.spec.js.mp4 (artifact from https://circleci.com/gh/badges/shields/47779#artifacts/containers/0). At the end this should be shown: |
With version 3.2.0: |
I've kind of 'made it work' by adding a |
I can confirm that I am seeing large amounts of my recordings "frozen". The first few seconds of the video are fine and then the the video hangs for the rest of the test. Sometimes the video resumes for a short period later on in the tests, but only for a short while until it freezes again. This seems to be transient for me, not happening to any particular test all the time. This has been an issue ever since upgrading to 3.2.0 |
I also join and confirm this is an issue for us. The video starts fine for about 5sec, then it gets "stuck" or "frozen" and stays like that for the whole duration of the test, usually between 40sec to 1min30sec. |
We are also seeing this issue with recordings on our Cypress Dashboard using cypress v3.2.0. It doesn't happen on every video, but it does happen often (maybe 7 times out of 10). It will freeze around the 1 minute mark and sometimes recovers, sometimes doesn't, in which case we essentially lose the entire recording. I have tried with and without video compression and doesn't seem to impact. Our tests run on Jenkins. Happy to offer more info if I can! |
We have the same issue in https://github.com/badges/shields. Example videos https://52855-7910045-gh.circle-artifacts.com/0/root/project/cypress/videos/main-page.spec.js.mp4, https://53812-7910045-gh.circle-artifacts.com/0/root/project/cypress/videos/main-page.spec.js.mp4. But I think that these "frozen" videos are a separate problem. Original problem described in this issue is about incomplete videos. |
@platan I agree, the issue with the Test Runner rendering 'freezing' during video record is a different issue than a video ending prematurely - so that the last frames of the test running are not present at all in the video. @pisti2010 @maryhipp Can you open a separate issue about 'freezing' videos? |
❗️ I opened a new issue for when the UI appears to 'freeze' or be frozen during the video recording here: #4722 ❓ If you're having the issue where the video recording clearly finishes without the last frames of the test run being recorded at all - please comment in this issue, ideally with all of your environment information:
|
I'm also having this issue. The recording is missing at least 2-3 seconds (maybe more) from the end. (e.g. the video ends before the last test is even in progress). I've observed this when running cypress locally with This is with Cypress 3.4.0. |
Let me take a look, because missing last frames of the video are very annoying, seeing it in https://github.com/bahmutov/cypress-test-clock We should probably wait better for the video frames to arrive after the spec is over and before we close the Electron browser. |
Having thought about this a little more - I wonder if what I was seeing is more related to #4722 - Perhaps the video is freezing during the last test and so it appears as though the video is being cut off when actually it's missing frames because of the freezing… |
yeah @WillsB3 the freezing of the video seems to be a different issue from us closing the Electron before last video frames are received and encoded. |
The code for this is done in cypress-io/cypress#4804, but has yet to be released. |
Released in |
I'm using Cypress v3.5.0, but still I'm not getting full video execution of my spec file run. |
If you're experiencing a bug similar to this in Cypress, please open a new issue with a fully reproducible example that we can run. There may be a specific edge case with the issue that we need more detail to fix. |
Current behavior:
When running with
cypress run --record
, the generated mp4 video file is incomplete, it does not wait for testing to be finished.Desired behavior:
The generated video file should be able to record the whole testing process.
Steps to reproduce:
Check an example here in Cypress Dashboard: (it's a public project so I assume you can all access this)
https://dashboard.cypress.io/#/projects/nf8wkk/runs
There are 2 runs, one is recored from Mac, another one is from Linux on Travis CI, the generated videos files from both of them are incomplete.
Here is my project for reference https://github.com/PinkyJie/cypress-auto-stub-example
Versions
Cypress: 3.1.0
System: Mac 10.12
Browser: Chrome 68
The text was updated successfully, but these errors were encountered: