Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate adding support for ts-node/esm #21939

Closed
tgriesser opened this issue May 31, 2022 · 2 comments · Fixed by #22118
Closed

Investigate adding support for ts-node/esm #21939

tgriesser opened this issue May 31, 2022 · 2 comments · Fixed by #22118
Assignees

Comments

@tgriesser
Copy link
Member

tgriesser commented May 31, 2022

Current behavior

In 10.0 using package.json with "type": "module" with .ts will not work out of the box without esbuild installed.

Desired behavior

Cypress should use the ts-node/esm builder to support loading .ts from esmodules. https://github.com/TypeStrong/ts-node#commonjs-vs-native-ecmascript-modules

Test code to reproduce

cd system-tests
yarn test config_modules_spec

config-cjs-and-esm/config-with-ts-module fails but it should pass

Cypress Version

10.0

Other

Related to #21574

@lmiller1990
Copy link
Contributor

lmiller1990 commented Jun 6, 2022

This will come for the ride with #22074 most likely! The core problem is the same: need better es module support. I am working on it, so I will assign this to myself.

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: routed to e2e-core labels Jun 6, 2022
@lmiller1990
Copy link
Contributor

WIP PR: #22118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants