Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: System notification on failure of test(s) #2145

Open
reintroducing opened this issue Jul 13, 2018 · 3 comments
Open

Feature: System notification on failure of test(s) #2145

reintroducing opened this issue Jul 13, 2018 · 3 comments
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory stage: ready for work The issue is reproducible and in scope type: feature New feature that does not currently exist

Comments

@reintroducing
Copy link

Current behavior:

Test failure shows up in the Cypress app.

Desired behavior:

In much the same way that you can do a Gulp notification using gulp-notify to show a system notification for, perhaps, an ESLint failure, it would be great to also be able to do this with Cypress when a test fails. The use case is running the Cypress app in the background running your tests against your local development environment while you develop. I have Cypress running and every time I save my JS files Cypress silently runs the tests. Unless I click over to the app and see I've broken something, I won't know that a test is failing.

This type of real-time feedback would be huge on every save to catch if you've just caused a regression to happen with your latest changes. I would love it if I didn't have to go back to the app to check if something is failing every time and be notified of this.

Versions

All.

@reintroducing reintroducing changed the title System notification on failure of test(s) Feature: System notification on failure of test(s) Jul 13, 2018
@jennifer-shehane
Copy link
Member

Thanks for opening this issue. We actually did discuss this before and felt this was a great idea. 👍

We would likely implement this through Electron's Notifications

@jennifer-shehane jennifer-shehane added type: feature New feature that does not currently exist stage: ready for work The issue is reproducible and in scope pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory labels Nov 30, 2018
@sainthkh
Copy link
Contributor

We can implement this with node-notifier. But it might mean to bundle some exe files into our electron bundle. While the file sizes are small (<1MB combined), but I cannot be sure if it's OK to add them or not.

@distante
Copy link

jest also uses node-notifier but does not bundle the dependency, instead, when the user starts jest with the --notify flag, it fails and ask the user to install node-notifier as dev dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory stage: ready for work The issue is reproducible and in scope type: feature New feature that does not currently exist
Projects
None yet
Development

No branches or pull requests

4 participants