Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the binary fails to download add a message about proxy #1662

Closed
bahmutov opened this issue May 2, 2018 · 3 comments · Fixed by #4705
Closed

When the binary fails to download add a message about proxy #1662

bahmutov opened this issue May 2, 2018 · 3 comments · Fixed by #4705
Assignees
@flotwig
Labels
cli type: enhancement Requested enhancement of existing feature

Comments

@bahmutov
Copy link
Contributor

bahmutov commented May 2, 2018

In CLI if the binary download fails, in the error message tell about proxy environment variables.
@bahmutov bahmutov added the cli label May 2, 2018
@bahmutov bahmutov self-assigned this May 2, 2018
@bahmutov bahmutov mentioned this issue May 2, 2018
Closed
@jennifer-shehane jennifer-shehane added type: enhancement Requested enhancement of existing feature stage: ready for work The issue is reproducible and in scope labels May 2, 2018
@jennifer-shehane jennifer-shehane assigned flotwig and unassigned bahmutov Jul 12, 2019
@flotwig
Copy link
Contributor

flotwig commented Jul 12, 2019

Could probably also use NPM's http proxy config as a fallback, to prevent stuff like this:

#3841 (comment)

@flotwig flotwig mentioned this issue Jul 12, 2019
Merged
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: ready for work The issue is reproducible and in scope stage: needs review The PR code is done & tested, needs review stage: work in progress labels Jul 12, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 15, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 15, 2019

The code for this is done in cypress-io/cypress#4705, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

Released in 3.4.1.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flotwig flotwig

Labels
cli type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention HTTP_PROXY if download error occurs; fall back to NPM's proxy… cypress-io/cypress
3 participants
@flotwig @jennifer-shehane @bahmutov