-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgade jQuery dependency to 3.x #1215
Comments
Updating jQuery is quite a big task, as many of our traversal api commands directly use jQuery. I updated jQuery from 2.1.4 to 2.2.4 and just remember it needing a lot of oversight to ensure things were working as intended. |
There is no fix/patch for jQuery v2.x and it's only fixed on v3 |
Yeah, I mean, anyone can open a pull request to update jQuery, the main thing to look for is failing tests after that - see what's changed and fix them up. https://github.com/cypress-io/cypress/blob/develop/packages/driver/package.json#L38 |
yeah, need to start this work by making a branch, pull request and then seeing which tests (if any) start breaking |
I've opened a PR and began outlining work that is necessary to upgrade. Any help would be appreciated! 😄 #1229 |
The code for this is done in cypress-io/cypress#1229, but has yet to be released. |
Released in |
GitHub has security vulnerability against our 2.x version in packages/server/package.json. We should just upgrade to 3.x
The text was updated successfully, but these errors were encountered: