Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgade jQuery dependency to 3.x #1215

Closed
bahmutov opened this issue Jan 22, 2018 · 7 comments · Fixed by #1229
Closed

Upgade jQuery dependency to 3.x #1215

bahmutov opened this issue Jan 22, 2018 · 7 comments · Fixed by #1229
Labels
pkg/driver This is due to an issue in the packages/driver directory

Comments

@bahmutov
Copy link
Contributor

GitHub has security vulnerability against our 2.x version in packages/server/package.json. We should just upgrade to 3.x

screen shot 2018-01-22 at 12 38 13 pm

screen shot 2018-01-22 at 12 38 39 pm

@jennifer-shehane
Copy link
Member

Updating jQuery is quite a big task, as many of our traversal api commands directly use jQuery. I updated jQuery from 2.1.4 to 2.2.4 and just remember it needing a lot of oversight to ensure things were working as intended.

@jennifer-shehane jennifer-shehane added pkg/driver This is due to an issue in the packages/driver directory stage: ready for work The issue is reproducible and in scope labels Jan 22, 2018
@joyarzun
Copy link

There is no fix/patch for jQuery v2.x and it's only fixed on v3
jquery/jquery#2432 (comment)

@jennifer-shehane
Copy link
Member

Yeah, I mean, anyone can open a pull request to update jQuery, the main thing to look for is failing tests after that - see what's changed and fix them up. https://github.com/cypress-io/cypress/blob/develop/packages/driver/package.json#L38

@bahmutov
Copy link
Contributor Author

yeah, need to start this work by making a branch, pull request and then seeing which tests (if any) start breaking

@jennifer-shehane
Copy link
Member

I've opened a PR and began outlining work that is necessary to upgrade. Any help would be appreciated! 😄 #1229

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 25, 2019

The code for this is done in cypress-io/cypress#1229, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release stage: ready for work The issue is reproducible and in scope and removed stage: needs review The PR code is done & tested, needs review stage: pending release labels Sep 25, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@cypress-bot cypress-bot bot removed the stage: ready for work The issue is reproducible and in scope label Oct 23, 2019
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/driver This is due to an issue in the packages/driver directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants