Skip to content

Commit b6aaa99

Browse files
committed
address review feedback
1 parent 7560ad1 commit b6aaa99

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

circle.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -152,25 +152,27 @@ commands:
152152
command: node scripts/circle-cache.js --action unpack
153153

154154
restore_cached_system_tests_deps:
155+
description: 'Restore the cached node_modules for projects in "system-tests/projects/**"'
155156
steps:
156157
- run:
157158
name: Generate Circle Cache key for system tests
158159
command: yarn workspace @tooling/system-tests cache:key > system_tests_cache_key
159160
- restore_cache:
160161
name: Restore system tests node_modules cache
161162
keys:
162-
- v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-node-modules-cache-{{ checksum "system_tests_cache_key" }}
163-
- v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-node-modules-cache-
163+
- v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-projects-node-modules-cache-{{ checksum "system_tests_cache_key" }}
164+
- v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-projects-node-modules-cache-
164165

165166
update_cached_system_tests_deps:
167+
description: 'Update the cached node_modules for projects in "system-tests/projects/**"'
166168
steps:
167169
- run:
168170
name: Generate Circle Cache key for system tests
169171
command: yarn workspace @tooling/system-tests cache:key > system_tests_cache_key
170172
- restore_cache:
171173
name: Restore cache state, to check for known modules cache existence
172174
keys:
173-
- v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-node-modules-cache-state-{{ checksum "system_tests_cache_key" }}
175+
- v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-projects-node-modules-cache-state-{{ checksum "system_tests_cache_key" }}
174176
- run:
175177
name: Bail if specific cache exists
176178
command: |
@@ -184,13 +186,13 @@ commands:
184186
command: yarn workspace @tooling/system-tests projects:yarn:install
185187
- save_cache:
186188
name: Save system tests node_modules cache
187-
key: v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-node-modules-cache-{{ checksum "system_tests_cache_key" }}
189+
key: v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-projects-node-modules-cache-{{ checksum "system_tests_cache_key" }}
188190
paths:
189191
- ~/.cache/cy-system-tests-node-modules
190192
- run: touch system_tests_node_modules_installed
191193
- save_cache:
192194
name: Save system tests node_modules cache state key
193-
key: v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-node-modules-cache-state-{{ checksum "system_tests_cache_key" }}
195+
key: v{{ .Environment.CACHE_VERSION }}-{{ arch }}-system-tests-projects-node-modules-cache-state-{{ checksum "system_tests_cache_key" }}
194196
paths:
195197
- system_tests_node_modules_installed
196198

@@ -2075,20 +2077,16 @@ linux-workflow: &linux-workflow
20752077
- build
20762078
- system-tests-chrome:
20772079
requires:
2078-
- build
20792080
- system-tests-node-modules-install
20802081
- system-tests-electron:
20812082
requires:
2082-
- build
20832083
- system-tests-node-modules-install
20842084
- system-tests-firefox:
20852085
requires:
2086-
- build
20872086
- system-tests-node-modules-install
20882087
- system-tests-non-root:
20892088
executor: non-root-docker-user
20902089
requires:
2091-
- build
20922090
- system-tests-node-modules-install
20932091
- driver-integration-tests-chrome:
20942092
requires:

0 commit comments

Comments
 (0)