Loading a cross domain page won't happen until the spec bridge is active (or a timeout will happen)

Author: mjhenkes

packages/driver/cypress/integration/e2e/multi-domain/navigation_spec.ts

@@ -237,27 +237,3 @@ describe('delayed navigation', { experimentalSessionSupport: true, defaultComman
     })
   })
 })
-
-// @ts-ignore / session support is needed for visiting about:blank between tests
-describe('sub domain window loads before multi-domain command', { experimentalSessionSupport: true }, () => {
-  beforeEach(() => {
-    cy.visit('/fixtures/multi-domain.html')
-    cy.get('a[data-cy="multi-domain-secondary-link"]').click()
-  })
-
-  it('establish a foobar spec bridge', () => {
-    cy.switchToDomain('http://foobar.com:3500', () => {
-      cy.get('a[data-cy="multi-domain-page"]')
-    })
-  })
-
-  it('page load before switchToDomain command when spec bridge is already established', () => {
-    return new Promise<void>((resolve) => {
-      setTimeout(() => {
-        cy.switchToDomain('http://foobar.com:3500', () => {
-          cy.get('a[data-cy="multi-domain-page"]')
-        }).then(resolve)
-      }, 2100)// this number should be larger than the delay cross origin domains.
-    })
-  })
-})

packages/driver/src/multi-domain/cypress.ts

@@ -100,8 +100,7 @@ const onBeforeAppWindowLoad = (Cypress: Cypress.Cypress, cy: $Cy) => (autWindow:
   cy.overrides.wrapNativeMethods(autWindow)
 
   const onWindowLoadPrimary = ({ url }) => {
-    // If the primary domain has indicated a load event, set stability to undefined, not true since the load happened in another domain.
-    cy.isStable(undefined, 'primary onload')
+    cy.isStable(true, 'primary onload')
     Cypress.emit('internal:window:load', { type: 'cross:domain', url })
   }
 

packages/driver/src/multi-domain/domain_fn.ts

@@ -55,21 +55,6 @@ const rehydrateRunnable = (data: serializedRunnable): Runnable|Test => {
 
 export const handleDomainFn = (Cypress: Cypress.Cypress, cy: $Cy) => {
   const reset = (state) => {
-    // If stability is true in this domain, that means this domain has loaded itself, in that case trust the domain and run the next command.
-    // We also wish to preserve the stability state through the state refresh.
-    if (cy.state('isStable')) {
-      // If this state is stable there is a good chance that the primary domain was not listening, resend the load event.
-      Cypress.specBridgeCommunicator.toPrimary('window:load', { url: cy.getRemoteLocation('href') })
-
-      state.isStable = true
-    } else {
-      // We specifically don't call 'cy.isStable' here because we don't want to inject another load event.
-      if (state.isStable) {
-        // If stability is established in a different domain, set this domain to undefined
-        state.isStable = undefined
-      }
-    }
-
     cy.reset({})
 
     const stateUpdates = {

packages/runner-shared/src/event-manager.js

@@ -532,9 +532,7 @@ export const eventManager = {
       // Only listen to window load events from the most recent secondary domain, This prevents nondeterminism in the case where we redirect to an already
       // established spec bridge, but one that is not the current or next switchToDomain command.
       if (cy.state('latestActiveDomain') === domain) {
-        // Since stability was established in another domain set stable to undefined, not true. Undefined and true are treated the same stability.ts, but
-        // it allows us to distinguish between a load event that ocurred in this domain and some that didn't (or the initial state)
-        cy.isStable(undefined, 'load')
+        cy.isStable(true, 'load')
         // Prints out the newly loaded URL
         Cypress.emit('internal:window:load', { type: 'cross:domain', url })
       }