fix(launcher): detect Firefox installed in AppData on Windows (#8460)

Author: flotwig

packages/launcher/__snapshots__/windows_spec.ts.js

@@ -182,3 +182,63 @@ exports['windows browser detection detects new Chrome 64-bit app path 1'] = {
   "version": "4.4.4",
   "path": "C:/Program Files/Google/Chrome/Application/chrome.exe"
 }
+
+exports['windows browser detection detects local Firefox installs 1'] = [
+  {
+    "name": "firefox",
+    "family": "firefox",
+    "channel": "stable",
+    "displayName": "Firefox",
+    "info": "Firefox support is currently in beta! You can help us continue to improve the Cypress + Firefox experience by [reporting any issues you find](https://on.cypress.io/new-issue).",
+    "versionRegex": {},
+    "binary": "firefox",
+    "path": "C:/Users/flotwig/AppData/Local/Mozilla Firefox/firefox.exe",
+    "version": "100",
+    "findAppParams": {
+      "appName": "Firefox.app",
+      "executable": "Contents/MacOS/firefox-bin",
+      "appId": "org.mozilla.firefox",
+      "versionProperty": "CFBundleShortVersionString"
+    }
+  },
+  {
+    "name": "firefox",
+    "family": "firefox",
+    "channel": "dev",
+    "displayName": "Firefox Developer Edition",
+    "info": "Firefox support is currently in beta! You can help us continue to improve the Cypress + Firefox experience by [reporting any issues you find](https://on.cypress.io/new-issue).",
+    "versionRegex": {},
+    "binary": [
+      "firefox-developer-edition",
+      "firefox"
+    ],
+    "path": "C:/Users/flotwig/AppData/Local/Firefox Developer Edition/firefox.exe",
+    "version": "300",
+    "findAppParams": {
+      "appName": "Firefox Developer Edition.app",
+      "executable": "Contents/MacOS/firefox-bin",
+      "appId": "org.mozilla.firefoxdeveloperedition",
+      "versionProperty": "CFBundleShortVersionString"
+    }
+  },
+  {
+    "name": "firefox",
+    "family": "firefox",
+    "channel": "nightly",
+    "displayName": "Firefox Nightly",
+    "info": "Firefox support is currently in beta! You can help us continue to improve the Cypress + Firefox experience by [reporting any issues you find](https://on.cypress.io/new-issue).",
+    "versionRegex": {},
+    "binary": [
+      "firefox-nightly",
+      "firefox-trunk"
+    ],
+    "path": "C:/Users/flotwig/AppData/Local/Firefox Nightly/firefox.exe",
+    "version": "200",
+    "findAppParams": {
+      "appName": "Firefox Nightly.app",
+      "executable": "Contents/MacOS/firefox-bin",
+      "appId": "org.mozilla.nightly",
+      "versionProperty": "CFBundleShortVersionString"
+    }
+  }
+]

packages/launcher/lib/windows/index.ts

@@ -42,6 +42,13 @@ function getFirefoxPaths (editionFolder) {
     .map((programFiles) => {
       return normalize(`C:/${programFiles}/${editionFolder}/firefox.exe`)
     })
+    .concat(normalize(join(
+      os.homedir(),
+      'AppData',
+      'Local',
+      editionFolder,
+      'firefox.exe',
+    )))
   }
 }
 

packages/launcher/test/unit/windows_spec.ts

@@ -9,6 +9,7 @@ import Bluebird from 'bluebird'
 import fse from 'fs-extra'
 import os from 'os'
 import snapshot from 'snap-shot-it'
+import { Browser } from '../../lib/types'
 
 function stubBrowser (path: string, version: string) {
   path = normalize(path.replace(/\\/g, '\\\\'))
@@ -22,6 +23,15 @@ function stubBrowser (path: string, version: string) {
   .resolves(true)
 }
 
+function detect (goalBrowsers: Browser[]) {
+  return Bluebird.mapSeries(goalBrowsers, (browser) => {
+    return windowsHelper.detect(browser)
+    .then((foundBrowser) => {
+      return _.merge(browser, foundBrowser)
+    })
+  })
+}
+
 const HOMEDIR = 'C:/Users/flotwig'
 
 describe('windows browser detection', () => {
@@ -55,14 +65,7 @@ describe('windows browser detection', () => {
     // edge canary is installed in homedir
     stubBrowser(`${HOMEDIR}/AppData/Local/Microsoft/Edge SxS/Application/msedge.exe`, '14')
 
-    const detected = (await Bluebird.mapSeries(browsers, (browser) => {
-      return windowsHelper.detect(browser)
-      .then((foundBrowser) => {
-        return _.merge(browser, foundBrowser)
-      })
-    }))
-
-    snapshot(detected)
+    snapshot(await detect(browsers))
   })
 
   // @see https://github.com/cypress-io/cypress/issues/8425
@@ -73,6 +76,17 @@ describe('windows browser detection', () => {
     snapshot(await windowsHelper.detect(chrome))
   })
 
+  // @see https://github.com/cypress-io/cypress/issues/8432
+  it('detects local Firefox installs', async () => {
+    stubBrowser(`${HOMEDIR}/AppData/Local/Mozilla Firefox/firefox.exe`, '100')
+    stubBrowser(`${HOMEDIR}/AppData/Local/Firefox Nightly/firefox.exe`, '200')
+    stubBrowser(`${HOMEDIR}/AppData/Local/Firefox Developer Edition/firefox.exe`, '300')
+
+    const firefoxes = _.filter(browsers, { family: 'firefox' })
+
+    snapshot(await detect(firefoxes))
+  })
+
   context('#getVersionString', () => {
     it('runs wmic and returns output', async () => {
       stubBrowser('foo', 'bar')