breaking: default video configuration option to false (#27008)

* chore: update darwin v8 snapshot

* BREAKING CHANGE: set video to false by default (system tests need updating).

* Update cli/CHANGELOG.md

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

* chore: update type comments

* chore: update protocol snapshot

* run ci

* run ci

* set video to true for chrome browser crash test

* chore: put in workaround for failing system test spec to be fixed in 27062

* chore: allow retries on actionability tests to be at least one retry as the CI tests run faster without video on

* chore: fix flaky navigation test where done is called multiple times almsot always, but sometimes throws an error

---------

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Author: AtofStryker

.circleci/workflows.yml

@@ -2070,7 +2070,6 @@ jobs:
             CYPRESS_PROJECT_ID=$TEST_KITCHENSINK_PROJECT_ID \
             CYPRESS_RECORD_KEY=$TEST_KITCHENSINK_RECORD_KEY \
             CYPRESS_INTERNAL_ENV=staging \
-            CYPRESS_video=false \
             yarn cypress:run --project /tmp/cypress-example-kitchensink --record
       - store-npm-logs
 

cli/CHANGELOG.md

@@ -6,6 +6,7 @@ _Released 08/1/2023 (PENDING)_
 **Breaking Changes:**
 
 - The [`cy.readFile()`](/api/commands/readfile) command is now retry-able as a [query command](https://on.cypress.io/retry-ability). This should not affect any tests using it; the functionality is unchanged. However, it can no longer be overwritten using [`Cypress.Commands.overwrite()`](/api/cypress-api/custom-commands#Overwrite-Existing-Commands). Addressed in [#25595](https://github.com/cypress-io/cypress/pull/25595).
+- The [`video`](https://docs.cypress.io/guides/references/configuration#Videos) configuration option now defaults to `false`. Addresses [#26157](https://github.com/cypress-io/cypress/issues/26157).
 
 - The deprecated configuration option, `nodeVersion` has been removed. Addresses [#27016](https://github.com/cypress-io/cypress/issues/27016).
 

cli/types/cypress.d.ts

@@ -3007,8 +3007,8 @@ declare namespace Cypress {
      */
     videoCompression: number | boolean
     /**
-     * Whether Cypress will record a video of the test run when running headlessly.
-     * @default true
+     * Whether Cypress will record a video of the test run when executing in run mode.
+     * @default false
      */
     video: boolean
     /**

npm/grep/cypress.config.js

@@ -11,5 +11,4 @@ module.exports = defineConfig({
     specPattern: '**/spec.js',
   },
   fixturesFolder: false,
-  video: false,
 })

npm/react/cypress.config.js

@@ -1,7 +1,6 @@
 module.exports = {
   'viewportWidth': 400,
   'viewportHeight': 400,
-  'video': false,
   'projectId': 'z9dxah',
   'env': {
     'reactDevtools': true,

npm/vue/cypress.config.ts

@@ -3,7 +3,6 @@ import { defineConfig } from 'cypress'
 export default defineConfig({
   'viewportWidth': 500,
   'viewportHeight': 500,
-  'video': false,
   'responseTimeout': 2500,
   'projectId': '134ej7',
   'experimentalFetchPolyfill': true,

npm/webpack-preprocessor/test/e2e/helpers.js

@@ -91,9 +91,6 @@ exports.runTest = async (options = {}) => {
     spec: opts.spec,
     browser: opts.browser,
     exit: opts.exit,
-    config: {
-      video: false,
-    },
     dev: true,
   })
   .finally(() => {

packages/app/cypress/fixtures/debug-Failing/gql-CloudViewerAndProject_RequiredData.json

@@ -294,7 +294,7 @@
           "field": "userAgent"
         },
         {
-          "value": true,
+          "value": false,
           "from": "default",
           "field": "video"
         },

packages/app/cypress/fixtures/debug-Failing/gql-HeaderBar_HeaderBarQuery.json

@@ -270,7 +270,7 @@
           "field": "userAgent"
         },
         {
-          "value": true,
+          "value": false,
           "from": "default",
           "field": "video"
         },

packages/app/cypress/fixtures/debug-Failing/gql-SpecsPageContainer.json

@@ -655,7 +655,7 @@
           "field": "userAgent"
         },
         {
-          "value": true,
+          "value": false,
           "from": "default",
           "field": "video"
         },