WIP: Initial desktop-gui config change warning

cypress-io · Jan 23, 2019 · 6864507 · 6864507
1 parent c223551
commit 6864507
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/packages/desktop-gui/cypress/integration/warning_message_spec.coffee b/packages/desktop-gui/cypress/integration/warning_message_spec.coffee
@@ -80,3 +80,8 @@ describe "WarningMessage", ->
       .click()
       .then ->
         expect(@ipc.externalOpen).not.to.be.called
+
+  describe "for error type CONFIGURATION_CHANGED", ->
+    it "renders configuration change message with the correct file name"
+    it "is not dismissable"
+    it "can reload the project"
diff --git a/packages/desktop-gui/src/projects/projects-api.js b/packages/desktop-gui/src/projects/projects-api.js
@@ -156,7 +156,11 @@ const openProject = (project) => {
   })
 
   ipc.onConfigChanged(() => {
-    reopenProject(project)
+    // TODO decide if making this "fake" error is reasonable
+    project.setWarning({
+      isCypressErr: true,
+      type: 'CONFIGURATION_CHANGED',
+    })
   })
 
   ipc.onProjectError((__, error) => {

diff --git a/packages/server/lib/project.coffee b/packages/server/lib/project.coffee
@@ -217,6 +217,7 @@ class Project extends EE
 
         ## call our callback function
         ## when settings change!
+        ## TODO: pass the file path to the config:change event
         onSettingsChanged.call(@)
     }