fix socketspec

Author: flotwig

packages/socket/lib/socket.js

@@ -1,9 +1,9 @@
 const fs = require('fs')
 const server = require('socket.io')
-const path = require('path')
-const pkg = require('socket.io-client/package.json')
+const { version } = require('socket.io-client/package.json')
 const { client, circularParser } = require('./browser')
-const resolvePkg = require('resolve-pkg')
+
+const clientSource = require.resolve('socket.io-client/dist/socket.io.js')
 
 module.exports = {
   server,
@@ -13,17 +13,11 @@ module.exports = {
   circularParser,
 
   getPathToClientSource () {
-    const clientSource = resolvePkg('socket.io-client/dist/socket.io.js', { cwd: path.join(__dirname, '..', '..', '..') })
-
-    if (fs.existsSync(clientSource)) {
-      return clientSource
-    }
-
-    return require.resolve('socket.io-client/dist/socket.io.js')
+    return clientSource
   },
 
   getClientVersion () {
-    return pkg.version
+    return version
   },
 
   getClientSource () {

packages/socket/package.json

@@ -12,15 +12,15 @@
     "test-watch": "cross-env NODE_ENV=test mocha --watch"
   },
   "dependencies": {
-    "resolve-pkg": "2.0.0",
     "socket.io": "2.3.0",
     "socket.io-circular-parser": "cypress-io/socket.io-circular-parser#unpatched-has-binary-2",
     "socket.io-client": "2.3.0"
   },
   "devDependencies": {
     "chai": "3.5.0",
     "cross-env": "6.0.3",
-    "mocha": "3.5.3"
+    "mocha": "3.5.3",
+    "resolve-pkg": "2.0.0"
   },
   "files": [
     "lib",

packages/socket/test/socket_spec.js

@@ -18,7 +18,7 @@ describe('Socket', function () {
 
   context('.getPathToClientSource', function () {
     it('returns path to socket.io.js', function () {
-      const clientPath = path.join(resolvePkg('socket.io-client', { cwd: path.join(__dirname, '..', '..', '..') }), 'dist', 'socket.io.js')
+      const clientPath = path.join(resolvePkg('socket.io-client'), 'dist', 'socket.io.js')
 
       expect(lib.getPathToClientSource()).to.eq(clientPath)
     })
@@ -36,7 +36,7 @@ describe('Socket', function () {
 
   context('.getClientSource', function () {
     it('returns client source as a string', function (done) {
-      const clientPath = path.join(resolvePkg('socket.io-client', { cwd: path.join(__dirname, '..', '..', '..') }), 'dist', 'socket.io.js')
+      const clientPath = path.join(resolvePkg('socket.io-client'), 'dist', 'socket.io.js')
 
       fs.readFile(clientPath, 'utf8', function (err, str) {
         if (err) done(err)