Skip to content

Commit 3c3c094

Browse files
Shawn Taylormarktnoonan
andauthored
fix(unify): reporter styles (#19034)
Co-authored-by: Mark Noonan <mark@cypress.io>
1 parent 7a5cc0a commit 3c3c094

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

packages/app/src/runner/reporter.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ function renderReporter (
2929
store: MobxRunnerStore,
3030
eventManager: EventManager,
3131
) {
32-
class EmptyHeader extends window.UnifiedRunner.React.Component {
33-
render () {
34-
return window.UnifiedRunner.React.createElement('div')
35-
}
36-
}
37-
3832
const reporter = window.UnifiedRunner.React.createElement(window.UnifiedRunner.Reporter, {
3933
runMode: 'single' as const,
4034
runner: eventManager.reporterBus,
@@ -44,10 +38,6 @@ function renderReporter (
4438
error: null, // errorMessages.reporterError(props.state.scriptError, props.state.spec.relative),
4539
resetStatsOnSpecChange: true,
4640
experimentalStudioEnabled: false,
47-
// TODO: Are we re-skinning the Reporter header?
48-
// If so, with React or Vue?
49-
// For now, just render and empty div.
50-
renderReporterHeader: (props: null) => window.UnifiedRunner.React.createElement(EmptyHeader, props),
5141
})
5242

5343
window.UnifiedRunner.ReactDOM.render(reporter, root)

packages/reporter/src/lib/base.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,11 @@ body,div,dl,dt,dd,ul,ol,li,h1,h2,h3,h4,h5,h6,pre,code,form,fieldset,legend,input
4646
font-weight: bold;
4747
}
4848

49+
svg {
50+
display: inline-block;
51+
vertical-align: initial;
52+
}
53+
4954
em {
5055
font-style: italic;
5156
}

packages/reporter/src/runnables/runnables.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@
234234
}
235235

236236
.runnable-state-icon {
237+
flex-shrink: 0;
237238
margin-right: 5px;
238239
margin-top: 4px;
239240

0 commit comments

Comments
 (0)