test(deps): reconfigure for ESLint v9 (#1643)

update eslint to 9.30.1
update eslint-plugin-cypress to 5.1.0
add typescript-eslint 8.35.1
add @typescript-eslint/parser 8.35.1
remove eslint-config-prettier
remove eslint-plugin-prettier
remove eslint-config-react-app

Author: MikeMcC399

eslint.config.mjs

@@ -0,0 +1,46 @@
+import globals from 'globals'
+import { defineConfig } from 'eslint/config'
+import pluginJs from '@eslint/js'
+import pluginTs from 'typescript-eslint'
+import pluginTsParser from '@typescript-eslint/parser'
+import pluginCypress from 'eslint-plugin-cypress'
+
+export default defineConfig([
+  {
+    ignores: ['build/'],
+  },
+  {
+    files: ['**/*.ts'],
+    languageOptions: {
+      parser: pluginTsParser,
+    },
+  },
+  pluginJs.configs.recommended,
+  pluginTs.configs.recommended,
+  pluginCypress.configs.recommended,
+  {
+    rules: {
+      // TO-DO review violations of disabled rules
+      'no-empty': 'off',
+      'no-prototype-builtins': 'off',
+      'no-undef': 'off',
+      'no-unused-vars': 'off',
+      'prefer-const': 'off',
+      '@typescript-eslint/ban-ts-comment': 'off',
+      '@typescript-eslint/no-empty-object-type': 'off',
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-non-null-asserted-optional-chain': 'off',
+      '@typescript-eslint/no-unsafe-function-type': 'off',
+      '@typescript-eslint/no-unused-expressions': 'off',
+      '@typescript-eslint/no-wrapper-object-types': 'off',
+      '@typescript-eslint/no-unused-vars': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+      '@typescript-eslint/triple-slash-reference': 'off',
+    },
+    languageOptions: {
+      globals: {
+        ...globals.node,
+      },
+    }
+  }
+])

package.json

@@ -90,6 +90,7 @@
     "@types/validator": "13.7.2",
     "@types/webpack-env": "1.16.4",
     "@types/yup": "0.29.13",
+    "@typescript-eslint/parser": "^8.35.1",
     "@vitejs/plugin-react": "^4.0.2",
     "bcryptjs": "2.4.3",
     "concurrently": "9.1.2",
@@ -98,11 +99,8 @@
     "cross-env": "7.0.3",
     "cypress": "^14.3.2",
     "dotenv": "16.0.0",
-    "eslint": "^8.44.0",
-    "eslint-config-prettier": "8.10.0",
-    "eslint-config-react-app": "^7.0.1",
-    "eslint-plugin-cypress": "3.5.0",
-    "eslint-plugin-prettier": "^5.0.0",
+    "eslint": "^9.30.1",
+    "eslint-plugin-cypress": "^5.1.0",
     "express": "4.20.0",
     "express-jwt": "6.1.2",
     "express-paginate": "1.0.2",
@@ -132,6 +130,7 @@
     "start-server-and-test": "1.14.0",
     "ts-node": "10.9.2",
     "typescript": "5.8.3",
+    "typescript-eslint": "^8.35.1",
     "vite": "^4.4.2",
     "vite-plugin-eslint": "^1.8.1",
     "vite-plugin-istanbul": "^4.1.0",
@@ -195,23 +194,6 @@
   "engines": {
     "node": "^20.0.0 || ^22.0.0"
   },
-  "eslintConfig": {
-    "env": {
-      "cypress/globals": true
-    },
-    "extends": [
-      "react-app",
-      "plugin:prettier/recommended",
-      "plugin:cypress/recommended"
-    ],
-    "plugins": [
-      "cypress",
-      "prettier"
-    ],
-    "rules": {
-      "no-unused-expressions": 0
-    }
-  },
   "husky": {
     "hooks": {
       "pre-push": "yarn types"

scripts/seedDataUtils.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/first */
 require("dotenv").config();
 
 import shortid from "shortid";

src/components/MainLayout.tsx

@@ -92,7 +92,6 @@ const MainLayout: React.FC<Props> = ({ children, notificationsService, authServi
     if (!desktopDrawerOpen && aboveSmallBreakpoint) {
       openDesktopDrawer({ aboveSmallBreakpoint });
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [aboveSmallBreakpoint, desktopDrawerOpen]);
 
   return (

src/containers/AppAuth0.tsx

@@ -42,7 +42,6 @@ const AppAuth0: React.FC = () => {
 
   const [, , bankAccountsService] = useMachine(bankAccountsMachine);
 
-  // eslint-disable-next-line react-hooks/rules-of-hooks
   useEffect(() => {
     (async function waitForToken() {
       const token = await getAccessTokenSilently();

src/containers/AppGoogle.tsx

@@ -49,7 +49,6 @@ const AppGoogle: React.FC = () => {
 
   // @ts-ignore
   if (window.Cypress) {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     useEffect(() => {
       const { user, token } = JSON.parse(localStorage.getItem("googleCypress")!);
       authService.send("GOOGLE", {
@@ -58,7 +57,6 @@ const AppGoogle: React.FC = () => {
       });
     }, []);
   } else {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     useGoogleLogin({
       clientId: process.env.VITE_GOOGLE_CLIENTID!,
       onSuccess: (res) => {

src/containers/AppOkta.tsx

@@ -46,7 +46,6 @@ const AppOkta: React.FC = () => {
 
   // @ts-ignore
   if (window.Cypress && process.env.VITE_OKTA_PROGRAMMATIC) {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     useEffect(() => {
       const okta = JSON.parse(localStorage.getItem("oktaCypress")!);
       authService.send("OKTA", {
@@ -55,7 +54,6 @@ const AppOkta: React.FC = () => {
       });
     }, []);
   } else {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
     useEffect(() => {
       if (oktaAuthState.isAuthenticated) {
         oktaAuthService.getUser().then((user: any) => {