Skip to content

Added plugin for mock/fake geolocation and timezone #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pradapjackie
Copy link

@pradapjackie pradapjackie commented Jul 9, 2025

Plugin Name: cypress-geolocation-locale-faker
Plugin Link: https://www.npmjs.com/package/cypress-geolocation-locale-faker
GitHub Repository: https://github.com/pradapjackie/cypress-geolocation-locale-faker


✅ Plugin Quality Checklist

Requirement Status Notes
🚀 Works with latest Cypress Compatible with Cypress v13 (tested with cypress/included:14.5.1)
🛠 Plugin purpose is clearly documented Purpose documented in README.md
📝 Well-written documentation Includes usage examples, API description, and setup instructions
🔬 Tested using Cypress Example test using cy.visit() with faked geolocation, locale, and timezone
👷‍♀️ CI pipeline is passing GitHub Actions with start-server-and-test and cypress/included Docker image – CI Link

📋 Plugin Submission Requirements

  • 🚀 Works with the latest major version of Cypress
  • 🛠 Plugin purpose is clearly documented (README)
  • 📝 Well-written documentation – Example from Cypress Docs
  • 🔬 Tested using Cypress – CI test run
  • 👷‍♀️ CI pipeline is passing (GitHub Actions) – View CI Status

Copy link

netlify bot commented Jul 9, 2025

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 17d666b

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version of Cypress is 14.x and it's expected to release Cypress 15.x soon.

https://github.com/pradapjackie/cypress-geolocation-locale-faker/blob/ef2369aa05f19387e568eb1491d78703ccafbb5c/package.json#L16-L18

does not include Cypress 14:

  "peerDependencies": {
    "cypress": "^12.0.0 || ^13.0.0"
  },

https://github.com/pradapjackie/cypress-geolocation-locale-faker/blob/main/.github/workflows/ci.yml tests with an old version of Cypress

  test:
    runs-on: ubuntu-latest
    container: cypress/included:13.7.3

Your package.json does not include populated package-json fields


Note: It's up to the Cypress.io team to review your submission and decide whether to accept it. I'm an external contributor so I can only give you some advice. I can't approve anything.

Edit: resolved: Generally they will only accept submissions if the CLA agreement is signed.

@pradapjackie
Copy link
Author

@MikeMcC399 Thank you for the valuable feedback , I will apply the changes before End of today GST.

@MikeMcC399
Copy link
Contributor

@pradapjackie

The Cypress.io team is very busy with the next release of Cypress, so it may take them some time until they respond to you after you make your changes.

@pradapjackie pradapjackie marked this pull request as ready for review July 10, 2025 15:52
@pradapjackie pradapjackie requested a review from MikeMcC399 July 10, 2025 15:53
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you completed all the open actions, and the following commands now all produce results 👍🏻

npm view cypress-geolocation-locale-faker homepage
npm view cypress-geolocation-locale-faker
npm repo cypress-geolocation-locale-faker

I suggest to use also the following, however this is not a prerequisite for Cypress, just a suggestion for you:

You'll need to wait for the Cypress.io team now. That completes what I can do for you. Good luck!

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving here, to remove the flag that I requested changes.

As mentioned before, I don't have the authority to actually approve the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants