Skip to content

Conversation

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cypress-io/cypress-documentation/6gx66YLuAeqDx3iiUD92U8z3SHTM
✅ Preview: https://cypress-documentation-git-954-cypress-io.vercel.app

emilyrohrbough and others added 2 commits April 11, 2022 11:22
Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com>
default timeout was used. Fixed
[#19985](https://github.com/cypress-io/cypress/issues/19985).
- Updates were made to decrease the length of the Cypress cache path for Windows
to ensure installing pre-release versions of the Cypress binary are within the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to the pre-release section of our guides for this so people understand this is not a normal change to our released version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 39 to 44
- Fixed a regression in [9.2.0](/guides/references/changelog#9-2-0) which would
sometimes throw an expected error on navigation with `cy.back()` and
`cy.go()`. The changes in `9.2.0` were made to mitigate the Chrome ` v97+`
change which always triggered an extra load event when an iframe navigated due
to a url hashchange. This change was made to maintain how Cypress handles
navigation. Fixed [#19749](https://github.com/cypress-io/cypress/issues/19749)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unnecessary info that could confused users as it shouldn't affect them.

Suggested change
- Fixed a regression in [9.2.0](/guides/references/changelog#9-2-0) which would
sometimes throw an expected error on navigation with `cy.back()` and
`cy.go()`. The changes in `9.2.0` were made to mitigate the Chrome ` v97+`
change which always triggered an extra load event when an iframe navigated due
to a url hashchange. This change was made to maintain how Cypress handles
navigation. Fixed [#19749](https://github.com/cypress-io/cypress/issues/19749)
- Fixed a regression in [9.2.0](/guides/references/changelog#9-2-0) which would
sometimes throw an expected error on navigation with `cy.back()` and
`cy.go()`. Fixed [#19749](https://github.com/cypress-io/cypress/issues/19749)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplified: a3b549e (#4433)

emilyrohrbough and others added 3 commits April 11, 2022 12:35
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
@chrisbreiding chrisbreiding self-requested a review April 11, 2022 18:25
emilyrohrbough and others added 2 commits April 11, 2022 13:43
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
@ryanthemanuel ryanthemanuel merged commit 624abab into master Apr 11, 2022
@ryanthemanuel ryanthemanuel deleted the 9.5.4 branch April 11, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants