Skip to content

Commit 6d75aa1

Browse files
committed
Fixed the --wep-* and --wpa-* options (Gentoo#281099).
The constructors had wrong super calls, duh. And there was a typo in "ccmp". http://bugs.gentoo.org/show_bug.cgi?id=281099
1 parent 1e97d4a commit 6d75aa1

File tree

3 files changed

+22
-4
lines changed

3 files changed

+22
-4
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ check: check-nonm
77

88
check-nonm:
99
for T in `find . -name \*.py | xargs grep -l '>>>'`; do python $$T; done
10-
for T in test/test01*.py; do $$T; done
10+
for T in test/test01*.py; do PYTHONPATH=. $$T; done
1111

1212
install:
1313
$(SETUP) install

networkmanager/applet/settings.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class Wep(WiFi):
104104
def __init__(self, ssid, key, hashed_key=""):
105105
"One of key, hashed_key must be present"
106106

107-
super(WiFi, self).__init__(ssid)
107+
super(Wep, self).__init__(ssid)
108108
self["802-11-wireless"]["security"] = "802-11-wireless-security"
109109
self["802-11-wireless-security"] = {}
110110
self["802-11-wireless-security"]["key-mgmt"] = "none"
@@ -126,10 +126,10 @@ class WpaPsk(WiFi):
126126
def __init__(self, ssid, key, hashed_key=""):
127127
"One of key, hashed_key must be present"
128128

129-
super(WiFi, self).__init__(ssid)
129+
super(WpaPsk, self).__init__(ssid)
130130
self["802-11-wireless"]["security"] = "802-11-wireless-security"
131131
self["802-11-wireless-security"] = {}
132-
self["802-11-wireless-security"]["group"] = ["tkip", "cselfp"]
132+
self["802-11-wireless-security"]["group"] = ["tkip", "ccmp"]
133133
self["802-11-wireless-security"]["pairwise"] = ["tkip", "ccmp"]
134134
self["802-11-wireless-security"]["key-mgmt"] = "wpa-psk"
135135
if hashed_key == "":

test/test01-nofail.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
import sys
55
import unittest
66

7+
import networkmanager.applet.settings as settings
8+
79
class NoFail(unittest.TestCase):
810
def callIt(self, params):
911
cmd = sys.path[0] + '/../cnetworkmanager'
@@ -19,5 +21,21 @@ def testFail(self):
1921
def testHelp(self):
2022
self.callIt("--help")
2123

24+
class SettingsFactory(unittest.TestCase):
25+
def testWiFi(self):
26+
ssid = "foo"
27+
c = settings.WiFi(ssid)
28+
29+
def testWep(self):
30+
ssid = "foo"
31+
c1 = settings.Wep(ssid, "wep_pass")
32+
c2 = settings.Wep(ssid, "", "ffffffffffffffffffffffffff")
33+
34+
def testWpa(self):
35+
ssid = "foo"
36+
c1 = settings.WpaPsk(ssid, "wep_pass")
37+
c2 = settings.WpaPsk(ssid, "", "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
38+
39+
2240
if __name__ == '__main__':
2341
unittest.main()

0 commit comments

Comments
 (0)