Skip to content

CM-40223 - Fix empty IaC scan results on Windows #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

CM-40223 - Fix empty IaC scan results on Windows #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [Unreleased]

- Fix empty IaC scan results on Windows

## [v1.9.3]

- Rework scan results handling
Expand Down Expand Up @@ -111,4 +115,6 @@ The first stable release with the support of Secrets, SCA, TreeView, Violation C

[v1.0.1]: https://github.com/cycodehq/vscode-extension/releases/tag/v1.0.1

[v1.0.0]: https://github.com/cycodehq/vscode-extension/releases/tag/v1.0.0
[v1.0.0]: https://github.com/cycodehq/vscode-extension/releases/tag/v1.0.0

[Unreleased]: https://github.com/cycodehq/vscode-extension/compare/v1.9.3...HEAD
3 changes: 2 additions & 1 deletion src/services/scanners/IacScanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {ScanType} from '../../constants';
import {VscodeStates} from '../../utils/states';
import {captureException} from '../../sentry';
import {handleScanResult} from './common';
import * as fs from 'node:fs';

interface IacScanParams {
pathToScan: string;
Expand Down Expand Up @@ -76,7 +77,7 @@ const filterUnsupportedIacDetections = (result: IacScanResult): IacScanResult =>
// TF plans are virtual files what is not exist in the file system
// "file_name": "1711298252-/Users/ilyasiamionau/projects/cycode/ilya-siamionau-payloads/tfplan.tf",
// skip such detections
return detection.detection_details.file_name.startsWith('/');
return fs.existsSync(detection.detection_details.file_name);
});

return result;
Expand Down
Loading