[-] fix QueryMeasurements nil pointer dereference, fixes #766
#767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `SourceConn` passed to reapMetricMeasurements() it's crucial to keep the existing source with connection alive, so the reaper keeps it's work. And there is no need to close the connection because it might be used right now in some metric fetcher. Let Reaper to cancel all disabled monitored sources in the main loop of Reap() function.
Pull Request Test Coverage Report for Build 15214258306Details
💛 - Coveralls |
pashagolub
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceConns.SyncFromReader()Since
SourceConnpassed toreapMetricMeasurements()it's crucial to keep the existing source with connection alive, so the reaper keeps it's work. And there is no need to close the connection because it might be used right now in some metric fetcher. Let Reaper to cancel all disabled monitored sources in the main loop ofReap()function.