Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] add commands config [init|upgrade], closes #514 #515

Merged
merged 7 commits into from
Aug 23, 2024

Conversation

pashagolub
Copy link
Collaborator

[] reorganize config sources for better modularity
[
] rename config package to cmdopts
[+] introduced new config commands for initializing and upgrading
[*] rename packages config types to CmdOpts
[+] add NewPostgresMetricReaderWriterConn()
[+] add NewPostgresSourceReaderWriterConn()

@pashagolub pashagolub self-assigned this Aug 22, 2024
@pashagolub pashagolub added the enhancement New feature or request label Aug 22, 2024
@coveralls
Copy link

coveralls commented Aug 22, 2024

Pull Request Test Coverage Report for Build 10525985234

Details

  • 76 of 150 (50.67%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 29.475%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sinks/postgres.go 1 2 50.0%
src/reaper/reaper.go 0 3 0.0%
src/main.go 0 13 0.0%
src/cmdopts/cmdoptions.go 22 39 56.41%
src/cmdopts/cmdconfig.go 34 74 45.95%
Files with Coverage Reduction New Missed Lines %
src/main.go 2 0.0%
Totals Coverage Status
Change from base Build 10525774792: 0.7%
Covered Lines: 1388
Relevant Lines: 4709

💛 - Coveralls

[*] reorganize config sources for better modularity
[*] rename `config` package to `cmdopts`
[+] introduced new `config` commands for initializing and upgrading
[*] rename packages config types to `CmdOpts`
[+] add `NewPostgresMetricReaderWriterConn()`
[+] add `NewPostgresSourceReaderWriterConn()`
@pashagolub pashagolub force-pushed the add-config-commands branch from 55061a6 to 8f8cf17 Compare August 23, 2024 12:41
@pashagolub pashagolub merged commit 96622a2 into master Aug 23, 2024
7 checks passed
@pashagolub pashagolub deleted the add-config-commands branch August 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants