Remove redundant LockId abstraction

Author: antonkomarev

src/LockId/PostgresLockId.php

@@ -42,22 +42,11 @@ private function __construct(
     public static function fromKeyValue(
         string $key,
         string $value = '',
-    ): self {
-        return self::fromLockId(
-            new LockId(
-                $key,
-                $value,
-            ),
-        );
-    }
-
-    public static function fromLockId(
-        LockId $lockId,
     ): self {
         return new self(
-            classId: self::convertStringToSignedInt32($lockId->key),
-            objectId: self::convertStringToSignedInt32($lockId->value),
-            humanReadableValue: (string)$lockId,
+            classId: self::convertStringToSignedInt32($key),
+            objectId: self::convertStringToSignedInt32($value),
+            humanReadableValue: "$key:$value",
         );
     }
 

test/Integration/Locker/PostgresAdvisoryLockerTest.php

@@ -467,7 +467,7 @@ public function testItCannotAcquireLockWithinTransactionNotInTransaction(): void
     {
         $this->expectException(LogicException::class);
         $this->expectExceptionMessage(
-            'Transaction-level advisory lock `test` cannot be acquired outside of transaction',
+            'Transaction-level advisory lock `test:` cannot be acquired outside of transaction',
         );
 
         $locker = $this->initLocker();

test/Unit/LockId/LockIdTest.php

@@ -13,7 +13,6 @@
 
 namespace Cog\Test\DbLocker\Unit\LockId;
 
-use Cog\DbLocker\LockId\LockId;
 use Cog\DbLocker\LockId\PostgresLockId;
 use Cog\Test\DbLocker\Unit\AbstractUnitTestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
@@ -54,34 +53,6 @@ public static function provideItCanCreatePostgresLockIdFromKeyValueData(): array
         ];
     }
 
-    #[DataProvider('provideItCanCreatePostgresLockIdFromLockIdData')]
-    public function testItCanCreatePostgresLockIdFromLockId(
-        LockId $lockId,
-        int $expectedClassId,
-        int $expectedObjectId,
-    ): void {
-        $postgresLockId = PostgresLockId::fromLockId($lockId);
-
-        $this->assertSame($expectedClassId, $postgresLockId->classId);
-        $this->assertSame($expectedObjectId, $postgresLockId->objectId);
-    }
-
-    public static function provideItCanCreatePostgresLockIdFromLockIdData(): array
-    {
-        return [
-            'key only' => [
-                new LockId('test'),
-                -662733300,
-                0,
-            ],
-            'key + value' => [
-                new LockId('test', '1'),
-                -662733300,
-                -2082672713,
-            ],
-        ];
-    }
-
     #[DataProvider('provideItCanCreatePostgresLockIdFromIntKeysData')]
     public function testItCanCreatePostgresLockIdFromIntKeys(
         int $classId,