Rewrite locker API

Author: antonkomarev

README.md

@@ -34,13 +34,13 @@ composer require cybercog/php-db-locker
 ```php
 $dbConnection = new PDO($dsn, $username, $password);
 
-$postgresLocker = new \Cog\DbLocker\Locker\PostgresAdvisoryLocker();
-$postgresLockId = \Cog\DbLocker\LockId\PostgresLockId::fromKeyValue('user', '4');
+$locker = new \Cog\DbLocker\Locker\PostgresAdvisoryLocker();
+$lockId = \Cog\DbLocker\LockId\PostgresLockId::fromKeyValue('user', '4');
 
 $dbConnection->beginTransaction();
-$isLockAcquired = $postgresLocker->acquireTransactionLevelLock(
+$isLockAcquired = $locker->acquireTransactionLevelLock(
     $dbConnection,
-    $postgresLockId,
+    $lockId,
     \Cog\DbLocker\Locker\PostgresAdvisoryLockLevelEnum::Transaction,
     \Cog\DbLocker\Locker\PostgresAdvisoryLockTypeEnum::NonBlocking,
     \Cog\DbLocker\Locker\PostgresLockModeEnum::Exclusive,
@@ -58,12 +58,12 @@ $dbConnection->commit();
 ```php
 $dbConnection = new PDO($dsn, $username, $password);
 
-$postgresLocker = new \Cog\DbLocker\Locker\PostgresAdvisoryLocker();
-$postgresLockId = \Cog\DbLocker\LockId\PostgresLockId::fromKeyValue('user', '4');
+$locker = new \Cog\DbLocker\Locker\PostgresAdvisoryLocker();
+$lockId = \Cog\DbLocker\LockId\PostgresLockId::fromKeyValue('user', '4');
 
-$isLockAcquired = $postgresLocker->acquireSessionLevelLock(
+$isLockAcquired = $locker->acquireSessionLevelLock(
     $dbConnection,
-    $postgresLockId,
+    $lockId,
     \Cog\DbLocker\Locker\PostgresAdvisoryLockLevelEnum::Session,
     \Cog\DbLocker\Locker\PostgresAdvisoryLockTypeEnum::NonBlocking,
     \Cog\DbLocker\Locker\PostgresLockModeEnum::Exclusive,
@@ -73,7 +73,7 @@ if ($isLockAcquired) {
 } else {
     // Execute logic if lock acquisition has been failed
 }
-$postgresLocker->releaseSessionLevelLock($dbConnection, $postgresLockId);
+$locker->releaseSessionLevelLock($dbConnection, $lockId);
 ```
 
 ## Changelog

src/Locker/PostgresAdvisoryLocker.php

@@ -92,12 +92,7 @@ public function releaseSessionLevelLock(
      */
     public function releaseAllSessionLevelLocks(
         PDO $dbConnection,
-        PostgresAdvisoryLockLevelEnum $level = PostgresAdvisoryLockLevelEnum::Session,
     ): void {
-        if ($level === PostgresAdvisoryLockLevelEnum::Transaction) {
-            throw new \InvalidArgumentException('Transaction-level advisory lock cannot be released');
-        }
-
         $statement = $dbConnection->prepare(
             <<<'SQL'
                 SELECT PG_ADVISORY_UNLOCK_ALL();

test/Integration/Locker/PostgresAdvisoryLockerTest.php

@@ -597,35 +597,6 @@ public function testItCannotReleaseLockWithTransactionScope(): void
         }
     }
 
-    public function testItCannotReleaseAllLocksWithTransactionScope(): void
-    {
-        $locker = $this->initLocker();
-        $dbConnection = $this->initPostgresPdoConnection();
-        $postgresLockId1 = PostgresLockId::fromKeyValue('test');
-        $postgresLockId2 = PostgresLockId::fromKeyValue('test2');
-        $locker->acquireSessionLevelLock(
-            $dbConnection,
-            $postgresLockId1,
-        );
-        $dbConnection->beginTransaction();
-        $locker->acquireTransactionLevelLock(
-            $dbConnection,
-            $postgresLockId2,
-        );
-
-        try {
-            $locker->releaseAllSessionLevelLocks(
-                $dbConnection,
-                PostgresAdvisoryLockLevelEnum::Transaction,
-            );
-        } catch (\InvalidArgumentException $exception) {
-            $this->assertSame(
-                'Transaction-level advisory lock cannot be released',
-                $exception->getMessage(),
-            );
-        }
-    }
-
     private function initLocker(): PostgresAdvisoryLocker
     {
         return new PostgresAdvisoryLocker();