Rewrite locker API

Author: antonkomarev

src/LockId/PostgresLockId.php

@@ -46,6 +46,8 @@ public static function fromKeyValue(
         return new self(
             classId: self::convertStringToSignedInt32($key),
             objectId: self::convertStringToSignedInt32($value),
+            // TODO: Do we need to sanitize it?
+            // TODO: Do we need to omit ":" on end if no value is passed
             humanReadableValue: "$key:$value",
         );
     }

test/Integration/Locker/PostgresAdvisoryLockerTest.php

@@ -27,7 +27,7 @@ final class PostgresAdvisoryLockerTest extends AbstractIntegrationTestCase
 
     #[DataProvider('provideItCanTryAcquireLockWithinSessionData')]
     public function testItCanTryAcquireLockWithinSession(
-        PostgresLockAccessModeEnum $mode,
+        PostgresLockAccessModeEnum $accessMode,
     ): void {
         $locker = $this->initLocker();
         $dbConnection = $this->initPostgresPdoConnection();
@@ -36,12 +36,12 @@ public function testItCanTryAcquireLockWithinSession(
         $isLockAcquired = $locker->acquireSessionLevelLock(
             $dbConnection,
             $postgresLockId,
-            accessMode: $mode,
+            accessMode: $accessMode,
         );
 
         $this->assertTrue($isLockAcquired);
         $this->assertPgAdvisoryLocksCount(1);
-        $this->assertPgAdvisoryLockExistsInConnection($dbConnection, $postgresLockId, $mode);
+        $this->assertPgAdvisoryLockExistsInConnection($dbConnection, $postgresLockId, $accessMode);
     }
 
     public static function provideItCanTryAcquireLockWithinSessionData(): array
@@ -58,7 +58,7 @@ public static function provideItCanTryAcquireLockWithinSessionData(): array
 
     #[DataProvider('provideItCanTryAcquireLockWithinTransactionData')]
     public function testItCanTryAcquireLockWithinTransaction(
-        PostgresLockAccessModeEnum $mode,
+        PostgresLockAccessModeEnum $accessMode,
     ): void {
         $locker = $this->initLocker();
         $dbConnection = $this->initPostgresPdoConnection();
@@ -68,12 +68,12 @@ public function testItCanTryAcquireLockWithinTransaction(
         $isLockAcquired = $locker->acquireTransactionLevelLock(
             $dbConnection,
             $postgresLockId,
-            accessMode: $mode,
+            accessMode: $accessMode,
         );
 
         $this->assertTrue($isLockAcquired);
         $this->assertPgAdvisoryLocksCount(1);
-        $this->assertPgAdvisoryLockExistsInConnection($dbConnection, $postgresLockId, $mode);
+        $this->assertPgAdvisoryLockExistsInConnection($dbConnection, $postgresLockId, $accessMode);
     }
 
     public static function provideItCanTryAcquireLockWithinTransactionData(): array
@@ -194,21 +194,21 @@ public function testItCannotAcquireSameLockInTwoConnections(): void
 
     #[DataProvider('provideItCanReleaseLockData')]
     public function testItCanReleaseLock(
-        PostgresLockAccessModeEnum $mode,
+        PostgresLockAccessModeEnum $accessMode,
     ): void {
         $locker = $this->initLocker();
         $dbConnection = $this->initPostgresPdoConnection();
         $postgresLockId = PostgresLockId::fromKeyValue('test');
         $locker->acquireSessionLevelLock(
             $dbConnection,
             $postgresLockId,
-            accessMode: $mode,
+            accessMode: $accessMode,
         );
 
         $isLockReleased = $locker->releaseSessionLevelLock(
             $dbConnection,
             $postgresLockId,
-            accessMode: $mode,
+            accessMode: $accessMode,
         );
 
         $this->assertTrue($isLockReleased);
@@ -256,12 +256,12 @@ public static function provideItCanNotReleaseLockOfDifferentModesData(): array
     {
         return [
             'release exclusive lock as share' => [
-                'acquireMode' => PostgresLockAccessModeEnum::Exclusive,
-                'releaseMode' => PostgresLockAccessModeEnum::Share,
+                'acquireAccessMode' => PostgresLockAccessModeEnum::Exclusive,
+                'releaseAccessMode' => PostgresLockAccessModeEnum::Share,
             ],
             'release share lock as exclusive' => [
-                'acquireMode' => PostgresLockAccessModeEnum::Share,
-                'releaseMode' => PostgresLockAccessModeEnum::Exclusive,
+                'acquireAccessMode' => PostgresLockAccessModeEnum::Share,
+                'releaseAccessMode' => PostgresLockAccessModeEnum::Exclusive,
             ],
         ];
     }