Rewrite locker API

Author: antonkomarev

src/Locker/PostgresAdvisoryLocker.php

@@ -63,13 +63,8 @@ public function acquireSessionLevelLock(
     public function releaseSessionLevelLock(
         PDO $dbConnection,
         PostgresLockId $postgresLockId,
-        PostgresAdvisoryLockLevelEnum $level = PostgresAdvisoryLockLevelEnum::Session,
         PostgresLockAccessModeEnum $accessMode = PostgresLockAccessModeEnum::Exclusive,
     ): bool {
-        if ($level === PostgresAdvisoryLockLevelEnum::Transaction) {
-            throw new \InvalidArgumentException('Transaction-level advisory lock cannot be released');
-        }
-
         $sql = match ($accessMode) {
             PostgresLockAccessModeEnum::Exclusive => 'SELECT PG_ADVISORY_UNLOCK(:class_id, :object_id);',
             PostgresLockAccessModeEnum::Share => 'SELECT PG_ADVISORY_UNLOCK_SHARED(:class_id, :object_id);',

test/Integration/Locker/PostgresAdvisoryLockerTest.php

@@ -14,7 +14,6 @@
 namespace Cog\Test\DbLocker\Integration\Locker;
 
 use Cog\DbLocker\Locker\PostgresAdvisoryLocker;
-use Cog\DbLocker\Locker\PostgresAdvisoryLockLevelEnum;
 use Cog\DbLocker\Locker\PostgresLockAccessModeEnum;
 use Cog\DbLocker\LockId\PostgresLockId;
 use Cog\Test\DbLocker\Integration\AbstractIntegrationTestCase;
@@ -567,36 +566,6 @@ public function testItCannotReleaseAllLocksAcquiredWithinTransaction(): void
         $this->assertPgAdvisoryLockExistsInConnection($dbConnection, $postgresLockId2);
     }
 
-    public function testItCannotReleaseLockWithTransactionScope(): void
-    {
-        $locker = $this->initLocker();
-        $dbConnection = $this->initPostgresPdoConnection();
-        $postgresLockId1 = PostgresLockId::fromKeyValue('test');
-        $postgresLockId2 = PostgresLockId::fromKeyValue('test2');
-        $locker->acquireSessionLevelLock(
-            $dbConnection,
-            $postgresLockId1,
-        );
-        $dbConnection->beginTransaction();
-        $locker->acquireTransactionLevelLock(
-            $dbConnection,
-            $postgresLockId2,
-        );
-
-        try {
-            $locker->releaseSessionLevelLock(
-                $dbConnection,
-                $postgresLockId2,
-                PostgresAdvisoryLockLevelEnum::Transaction,
-            );
-        } catch (\InvalidArgumentException $exception) {
-            $this->assertSame(
-                'Transaction-level advisory lock cannot be released',
-                $exception->getMessage(),
-            );
-        }
-    }
-
     private function initLocker(): PostgresAdvisoryLocker
     {
         return new PostgresAdvisoryLocker();