Open
Conversation
Member
|
Let's have further discussion on #1417 first. |
Member
|
Converting to draft until the issues in #1417 are resolved. |
Member
|
#1417 seems far enough along that I'm ready to take this as a merge -- |
Contributor
Author
Yes, I've been occupied with other things but I will revise this based on the discussion there shortly. |
Member
|
Hi @malcolmsailor -- do you have time to catch this up? it was very close to a merge. THANKS! |
Contributor
Author
|
I'll try to look into it this weekend |
Member
|
Hello -- just as a note (from the music21list Google Group) I'm taking a sabbatical from reviewing music21 issues and PRs until at least Jan 1, 2024, so this PR will be deferred until then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1417.
One question might be: do we want the writer to write "fast 3/8" in the case of fast 3/8, etc? I didn't implement this since my approach is to change the existing behavior as little as possible. But I'm inclined to think it might be better to be maximally explicit and write "fast 3/8".
Another question could be: is there such thing as "slow 9/8" or "slow 12/8", etc? And what about "slow 3/16" etc.? I only check for 3/8 and 6/8 since these are the only such meters mentioned in the docs as far as I could tell. And in fact I believe I have never even seen "slow 6/8", only "slow 3/8".