Skip to content

Commit f720782

Browse files
authored
Updating node to node 10 in tasks (microsoft#14019)
* Updating node to node 10 in tasks * Replacing deprecated MochaDone with Mocha.Done * Update common packages versions * Adding DockerV2 version changes * Updating docker-common-v2 version
1 parent 6ae75ce commit f720782

35 files changed

+3488
-511
lines changed

Tasks/DockerV2/Tests/L0.ts

Lines changed: 35 additions & 35 deletions
Large diffs are not rendered by default.

Tasks/DockerV2/package-lock.json

Lines changed: 468 additions & 63 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tasks/DockerV2/package.json

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
{
22
"dependencies": {
3-
"@types/mocha": "^2.2.5",
4-
"@types/node": "^6.0.101",
3+
"@types/mocha": "^5.2.7",
4+
"@types/node": "^10.17.0",
55
"@types/q": "^1.5.0",
6-
"azure-pipelines-tasks-docker-common-v2": "1.0.0",
6+
"@types/uuid": "^8.3.0",
7+
"azure-pipelines-task-lib": "^3.0.6-preview.0",
8+
"azure-pipelines-tasks-docker-common-v2": "2.0.1-preview.0",
79
"del": "2.2.0",
810
"esprima": "2.7.1",
911
"js-yaml": "3.6.1",
1012
"utility-common-v2": "file:../../_build/Tasks/Common/utility-common-v2-2.0.0.tgz"
13+
},
14+
"devDependencies": {
15+
"typescript": "4.0.2"
1116
}
1217
}

Tasks/DockerV2/task.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 2,
16-
"Minor": 176,
16+
"Minor": 181,
1717
"Patch": 0
1818
},
1919
"minimumAgentVersion": "2.172.0",
@@ -139,7 +139,7 @@
139139
"instanceNameFormat": "$(command)",
140140
"showEnvironmentVariables": true,
141141
"execution": {
142-
"Node": {
142+
"Node10": {
143143
"target": "docker.js"
144144
}
145145
},

Tasks/DockerV2/task.loc.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 2,
16-
"Minor": 176,
16+
"Minor": 181,
1717
"Patch": 0
1818
},
1919
"minimumAgentVersion": "2.172.0",
@@ -139,7 +139,7 @@
139139
"instanceNameFormat": "ms-resource:loc.instanceNameFormat",
140140
"showEnvironmentVariables": true,
141141
"execution": {
142-
"Node": {
142+
"Node10": {
143143
"target": "docker.js"
144144
}
145145
},

Tasks/HelmDeployV0/Tests/L0.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ describe("HelmDeployV0 Suite", function () {
3434
done();
3535
});
3636

37-
it("Run successfully with Helm install (version 3) with chart name", function (done: MochaDone) {
37+
it("Run successfully with Helm install (version 3) with chart name", function (done: Mocha.Done) {
3838
const tp = path.join(__dirname, "TestSetup.js");
3939
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
4040
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -56,7 +56,7 @@ describe("HelmDeployV0 Suite", function () {
5656
done();
5757
});
5858

59-
it("Run successfully with Helm install (version 3) with chart name when publishPipelineMetadata is set to false", function (done: MochaDone) {
59+
it("Run successfully with Helm install (version 3) with chart name when publishPipelineMetadata is set to false", function (done: Mocha.Done) {
6060
const tp = path.join(__dirname, "TestSetup.js");
6161
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
6262
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -78,7 +78,7 @@ describe("HelmDeployV0 Suite", function () {
7878
done();
7979
});
8080

81-
it("Run successfully with Helm install (version 2) with chart name", function (done: MochaDone) {
81+
it("Run successfully with Helm install (version 2) with chart name", function (done: Mocha.Done) {
8282
const tp = path.join(__dirname, "TestSetup.js");
8383
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
8484
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -98,7 +98,7 @@ describe("HelmDeployV0 Suite", function () {
9898
done();
9999
});
100100

101-
it("Run successfully with Helm install (version 3) with chart path", function (done: MochaDone) {
101+
it("Run successfully with Helm install (version 3) with chart path", function (done: Mocha.Done) {
102102
const tp = path.join(__dirname, "TestSetup.js");
103103
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
104104
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -118,7 +118,7 @@ describe("HelmDeployV0 Suite", function () {
118118
done();
119119
});
120120

121-
it("Run successfully with Helm install (version 3) when release name is not given", function (done: MochaDone) {
121+
it("Run successfully with Helm install (version 3) when release name is not given", function (done: Mocha.Done) {
122122
const tp = path.join(__dirname, "TestSetup.js");
123123
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
124124
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -137,7 +137,7 @@ describe("HelmDeployV0 Suite", function () {
137137
done();
138138
});
139139

140-
it("Run successfully with Helm install (version 3) when invalid chart version is given", function (done: MochaDone) {
140+
it("Run successfully with Helm install (version 3) when invalid chart version is given", function (done: Mocha.Done) {
141141
const tp = path.join(__dirname, "TestSetup.js");
142142
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
143143
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -158,7 +158,7 @@ describe("HelmDeployV0 Suite", function () {
158158
done();
159159
});
160160

161-
it("Run successfully with Helm upgrade (version 3) when chart name is given and release name is not", function (done: MochaDone) {
161+
it("Run successfully with Helm upgrade (version 3) when chart name is given and release name is not", function (done: Mocha.Done) {
162162
const tp = path.join(__dirname, "TestSetup.js");
163163
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
164164
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -176,7 +176,7 @@ describe("HelmDeployV0 Suite", function () {
176176
done();
177177
});
178178

179-
it("Run successfully with Helm upgrade (version 3) when chart name and release name are given", function (done: MochaDone) {
179+
it("Run successfully with Helm upgrade (version 3) when chart name and release name are given", function (done: Mocha.Done) {
180180
const tp = path.join(__dirname, "TestSetup.js");
181181
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
182182
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -195,7 +195,7 @@ describe("HelmDeployV0 Suite", function () {
195195
done();
196196
});
197197

198-
it("Run successfully with Helm init (version 2)", function (done: MochaDone) {
198+
it("Run successfully with Helm init (version 2)", function (done: Mocha.Done) {
199199
const tp = path.join(__dirname, "TestSetup.js");
200200
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
201201
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -208,7 +208,7 @@ describe("HelmDeployV0 Suite", function () {
208208
done();
209209
});
210210

211-
it("Helm init should fail (version 3)", function (done: MochaDone) {
211+
it("Helm init should fail (version 3)", function (done: Mocha.Done) {
212212
const tp = path.join(__dirname, "TestSetup.js");
213213
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
214214
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -222,7 +222,7 @@ describe("HelmDeployV0 Suite", function () {
222222
done();
223223
});
224224

225-
it("Run successfully with Helm package command (version 3)", function (done: MochaDone) {
225+
it("Run successfully with Helm package command (version 3)", function (done: Mocha.Done) {
226226
const tp = path.join(__dirname, "TestSetup.js");
227227
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
228228
process.env[shared.TestEnvVars.connectionType] = shared.ConnectionTypes.KubernetesServiceConnection;
@@ -239,7 +239,7 @@ describe("HelmDeployV0 Suite", function () {
239239
done();
240240
});
241241

242-
it("Run successfully with Helm save command (version 3)", function (done: MochaDone) {
242+
it("Run successfully with Helm save command (version 3)", function (done: Mocha.Done) {
243243
const tp = path.join(__dirname, "TestSetup.js");
244244
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
245245
process.env[shared.TestEnvVars.command] = shared.Commands.save;
@@ -261,7 +261,7 @@ describe("HelmDeployV0 Suite", function () {
261261
done();
262262
});
263263

264-
it("Helm same should fail (version 2)", function (done: MochaDone) {
264+
it("Helm same should fail (version 2)", function (done: Mocha.Done) {
265265
const tp = path.join(__dirname, "TestSetup.js");
266266
const tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
267267
process.env[shared.TestEnvVars.command] = shared.Commands.save;

0 commit comments

Comments
 (0)