typescript fix assignment expression name scope (#734)

Author: AndrewDant

src/languages/typescript.ts

@@ -183,6 +183,7 @@ const nodeMatchers: Partial<Record<ScopeType, NodeMatcherAlternative>> = {
     "optional_parameter.identifier!",
     "required_parameter.identifier!",
     "augmented_assignment_expression[left]",
+    "assignment_expression[left]",
   ],
   comment: "comment",
   regularExpression: "regex",

src/test/suite/fixtures/recorded/languages/typescript/changeName2.yml

@@ -0,0 +1,23 @@
+languageId: typescript
+command:
+  version: 1
+  spokenForm: change name
+  action: clearAndSetSelection
+  targets:
+    - type: primitive
+      modifier: {type: containingScope, scopeType: name, includeSiblings: false}
+initialState:
+  documentContents: this.leadingDelimiterRange_ = parameters.leadingDelimiterRange;
+  selections:
+    - anchor: {line: 0, character: 37}
+      active: {line: 0, character: 37}
+  marks: {}
+finalState:
+  documentContents: " = parameters.leadingDelimiterRange;"
+  selections:
+    - anchor: {line: 0, character: 0}
+      active: {line: 0, character: 0}
+  thatMark:
+    - anchor: {line: 0, character: 0}
+      active: {line: 0, character: 0}
+fullTargets: [{type: primitive, mark: {type: cursor}, selectionType: token, position: contents, insideOutsideType: inside, modifier: {type: containingScope, scopeType: name, includeSiblings: false}, isImplicit: false}]

src/test/suite/fixtures/recorded/languages/typescript/changeName3.yml

@@ -0,0 +1,23 @@
+languageId: typescript
+command:
+  version: 1
+  spokenForm: change name
+  action: clearAndSetSelection
+  targets:
+    - type: primitive
+      modifier: {type: containingScope, scopeType: name, includeSiblings: false}
+initialState:
+  documentContents: leadingDelimiterRange_[0] = parameters.leadingDelimiterRange;
+  selections:
+    - anchor: {line: 0, character: 36}
+      active: {line: 0, character: 36}
+  marks: {}
+finalState:
+  documentContents: " = parameters.leadingDelimiterRange;"
+  selections:
+    - anchor: {line: 0, character: 0}
+      active: {line: 0, character: 0}
+  thatMark:
+    - anchor: {line: 0, character: 0}
+      active: {line: 0, character: 0}
+fullTargets: [{type: primitive, mark: {type: cursor}, selectionType: token, position: contents, insideOutsideType: inside, modifier: {type: containingScope, scopeType: name, includeSiblings: false}, isImplicit: false}]

src/test/suite/fixtures/recorded/languages/typescript/changeName4.yml

@@ -0,0 +1,23 @@
+languageId: typescript
+command:
+  version: 1
+  spokenForm: change name
+  action: clearAndSetSelection
+  targets:
+    - type: primitive
+      modifier: {type: containingScope, scopeType: name, includeSiblings: false}
+initialState:
+  documentContents: let name = parameters.leadingDelimiterRange;
+  selections:
+    - anchor: {line: 0, character: 26}
+      active: {line: 0, character: 26}
+  marks: {}
+finalState:
+  documentContents: let  = parameters.leadingDelimiterRange;
+  selections:
+    - anchor: {line: 0, character: 4}
+      active: {line: 0, character: 4}
+  thatMark:
+    - anchor: {line: 0, character: 4}
+      active: {line: 0, character: 4}
+fullTargets: [{type: primitive, mark: {type: cursor}, selectionType: token, position: contents, insideOutsideType: inside, modifier: {type: containingScope, scopeType: name, includeSiblings: false}, isImplicit: false}]

src/test/suite/fixtures/recorded/languages/typescript/changeName5.yml

@@ -0,0 +1,23 @@
+languageId: typescript
+command:
+  version: 1
+  spokenForm: change name
+  action: clearAndSetSelection
+  targets:
+    - type: primitive
+      modifier: {type: containingScope, scopeType: name, includeSiblings: false}
+initialState:
+  documentContents: foo().bar = parameters.leadingDelimiterRange;
+  selections:
+    - anchor: {line: 0, character: 25}
+      active: {line: 0, character: 26}
+  marks: {}
+finalState:
+  documentContents: " = parameters.leadingDelimiterRange;"
+  selections:
+    - anchor: {line: 0, character: 0}
+      active: {line: 0, character: 0}
+  thatMark:
+    - anchor: {line: 0, character: 0}
+      active: {line: 0, character: 0}
+fullTargets: [{type: primitive, mark: {type: cursor}, selectionType: token, position: contents, insideOutsideType: inside, modifier: {type: containingScope, scopeType: name, includeSiblings: false}, isImplicit: false}]