Change surrounding delimiter api

Author: pokey

src/Types.ts

@@ -95,11 +95,15 @@ export type ScopeType =
   | "xmlEndTag"
   | "xmlStartTag";
 export type PieceType = "word" | "character";
+export type DelimiterInclusion =
+  | "excludeDelimiters"
+  | "includeDelimiters"
+  | "delimitersOnly";
 
 export interface SurroundingPairModifier {
   type: "surroundingPair";
   delimiter: Delimiter | null;
-  delimitersOnly: boolean;
+  delimiterInclusion: DelimiterInclusion;
 }
 export interface ContainingScopeModifier {
   type: "containingScope";

src/languages/surroundingPair.ts

@@ -3,6 +3,7 @@ import { Position, Selection } from "vscode";
 import { Point, SyntaxNode } from "web-tree-sitter";
 import {
   Delimiter,
+  DelimiterInclusion,
   NodeMatcher,
   NodeMatcherValue,
   SelectionWithEditor,
@@ -27,7 +28,7 @@ const leftToRightMap: Record<string, string> = Object.fromEntries(
 
 export function createSurroundingPairMatcher(
   delimiter: Delimiter | null,
-  delimitersOnly: boolean
+  delimiterInclusion: DelimiterInclusion
 ): NodeMatcher {
   return function nodeMatcher(
     selection: SelectionWithEditor,
@@ -67,56 +68,54 @@ export function createSurroundingPairMatcher(
     return extractSelection(
       leftDelimiterNode,
       rightDelimiterNode,
-      delimitersOnly
+      delimiterInclusion
     );
   };
 }
 
 function extractSelection(
   leftDelimiterNode: SyntaxNode,
   rightDelimiterNode: SyntaxNode,
-  delimitersOnly: boolean
+  delimiterInclusion: DelimiterInclusion
 ): NodeMatcherValue[] {
-  if (delimitersOnly === false) {
-    return [
-      {
-        node: leftDelimiterNode,
-        selection: {
-          selection: new Selection(
-            positionFromPoint(leftDelimiterNode.endPosition),
-            positionFromPoint(rightDelimiterNode.startPosition)
-          ),
-          context: {
-            outerSelection: new Selection(
-              positionFromPoint(leftDelimiterNode.startPosition),
-              positionFromPoint(rightDelimiterNode.endPosition)
-            ),
-          },
-        },
-      },
-    ];
-  } else {
-    return [
-      {
-        node: leftDelimiterNode,
-        selection: {
-          selection: new Selection(
-            positionFromPoint(leftDelimiterNode.startPosition),
-            positionFromPoint(leftDelimiterNode.endPosition)
-          ),
-          context: {},
-        },
-      },
-      {
-        node: rightDelimiterNode,
-        selection: {
-          selection: new Selection(
-            positionFromPoint(rightDelimiterNode.startPosition),
-            positionFromPoint(rightDelimiterNode.endPosition)
-          ),
-          context: {},
-        },
-      },
-    ];
+  var selections: Selection[];
+
+  switch (delimiterInclusion) {
+    case "includeDelimiters":
+      selections = [
+        new Selection(
+          positionFromPoint(leftDelimiterNode.startPosition),
+          positionFromPoint(rightDelimiterNode.endPosition)
+        ),
+      ];
+      break;
+    case "excludeDelimiters":
+      selections = [
+        new Selection(
+          positionFromPoint(leftDelimiterNode.endPosition),
+          positionFromPoint(rightDelimiterNode.startPosition)
+        ),
+      ];
+      break;
+    case "delimitersOnly":
+      selections = [
+        new Selection(
+          positionFromPoint(leftDelimiterNode.startPosition),
+          positionFromPoint(leftDelimiterNode.endPosition)
+        ),
+        new Selection(
+          positionFromPoint(rightDelimiterNode.startPosition),
+          positionFromPoint(rightDelimiterNode.endPosition)
+        ),
+      ];
+      break;
   }
+
+  return selections.map((selection) => ({
+    node: leftDelimiterNode,
+    selection: {
+      selection,
+      context: {},
+    },
+  }));
 }

src/processTargets.ts

@@ -1,5 +1,5 @@
 import update from "immutability-helper";
-import { concat, range, zip } from "lodash";
+import { concat, isEqual, range, zip } from "lodash";
 import * as vscode from "vscode";
 import { Location, Position, Range, Selection, TextDocument } from "vscode";
 import { SyntaxNode } from "web-tree-sitter";
@@ -427,7 +427,7 @@ function transformSelection(
 
         const nodeMatcher = createSurroundingPairMatcher(
           modifier.delimiter,
-          modifier.delimitersOnly
+          modifier.delimiterInclusion
         );
         let result = findNearestContainingAncestorNode(
           node,
@@ -656,12 +656,7 @@ function getTokenSelectionContext(
 // TODO Clean this up once we have rich targets and better polymorphic
 // selection contexts that indicate their type
 function isSelectionContextEmpty(selectionContext: SelectionContext) {
-  return (
-    selectionContext.isInDelimitedList == null &&
-    selectionContext.containingListDelimiter == null &&
-    selectionContext.leadingDelimiterRange == null &&
-    selectionContext.trailingDelimiterRange == null
-  );
+  return isEqual(selectionContext, {});
 }
 
 function getLineSelectionContext(