Update banks (#176)

Author: daninfpj

Makefile

@@ -50,5 +50,7 @@ release: test clean
 	python setup.py sdist bdist_wheel
 	twine upload dist/*
 
+compare-banks:
+	PYTHONPATH=. python scripts/compare_banks.py
 
-.PHONY: all install-test test format lint clean release
+.PHONY: all install-test test format lint clean release compare-banks

clabe/banks.py

@@ -40,7 +40,6 @@
     '140': '40140',
     '652': '90652',
     '688': '90688',
-    '126': '40126',
     '680': '90680',
     '723': '90723',
     '722': '90722',
@@ -58,7 +57,6 @@
     '902': '90902',
     '150': '40150',
     '136': '40136',
-    '686': '90686',
     '059': '40059',
     '110': '40110',
     '661': '90661',
@@ -70,7 +68,6 @@
     '600': '90600',
     '108': '40108',
     '132': '40132',
-    '613': '90613',
     '135': '37135',
     '710': '90710',
     '684': '90684',
@@ -82,7 +79,6 @@
     '157': '40157',
     '728': '90728',
     '646': '90646',
-    '648': '90648',
     '656': '90656',
     '617': '90617',
     '605': '90605',
@@ -91,6 +87,7 @@
     '113': '40113',
     '141': '40141',
     '715': '90715',
+    '732': '90732',
 }
 
 
@@ -105,7 +102,7 @@
     '90659': 'Asp Integra Opc',
     '40128': 'Autofin',
     '40127': 'Azteca',
-    '37166': 'Babien',
+    '37166': 'BaBien',
     '40030': 'Bajio',
     '40002': 'Banamex',
     '40154': 'Banco Covalto',
@@ -130,7 +127,7 @@
     '90683': 'Caja Telefonist',
     '90715': 'Cartera Digital',
     '90630': 'CB Intercam',
-    '40124': 'CBM Banco',
+    '40124': 'Citi Mexico',
     '40143': 'CI Banco',
     '90631': 'CI Bolsa',
     '90901': 'Cls',
@@ -139,7 +136,6 @@
     '40140': 'Consubanco',
     '90652': 'Credicapital',
     '90688': 'Crediclub',
-    '40126': 'Credit Suisse',
     '90680': 'Cristobal Colon',
     '90723': 'Cuenca',
     '40151': 'Donde',
@@ -156,7 +152,6 @@
     '90902': 'Indeval',
     '40150': 'Inmobiliario',
     '40136': 'Intercam Banco',
-    '90686': 'Invercap',
     '40059': 'Invex',
     '40110': 'JP Morgan',
     '90661': 'KLAR',
@@ -169,19 +164,18 @@
     '90600': 'Monexcb',
     '40108': 'Mufg',
     '40132': 'Multiva Banco',
-    '90613': 'Multiva Cbolsa',
     '37135': 'Nafin',
     '90638': 'NU MEXICO',
     '90710': 'NVIO',
     '40148': 'Pagatodo',
+    '90732': 'Peibo',
     '90620': 'Profuturo',
     '40156': 'Sabadell',
     '40014': 'Santander',
     '40044': 'Scotiabank',
     '40157': 'Shinhan',
     '90728': 'Spin by OXXO',
     '90646': 'STP',
-    '90648': 'Tactiv Cb',
     '90703': 'Tesored',
     '90684': 'Transfer',
     '90656': 'Unagra',

requirements-test.txt

@@ -3,4 +3,5 @@ pytest-cov==4.1.0
 black==22.8.0
 isort==5.11.5
 flake8==5.0.4
-mypy==1.4.1
+mypy==1.4.1
+requests==2.32.3

scripts/compare_banks.py

@@ -0,0 +1,70 @@
+from datetime import datetime
+
+import requests
+from clabe.banks import BANK_NAMES
+
+
+def fetch_banxico_data():
+    current_date = datetime.now().strftime('%d-%m-%Y')
+    url = f'https://www.banxico.org.mx/cep/instituciones.do?fecha={current_date}'
+    try:
+        response = requests.get(url)
+        response.raise_for_status()
+        data = response.json()
+        return dict(data.get('instituciones', []))
+    except Exception as e:
+        print(f'Error fetching data from Banxico: {e}')
+        return {}
+
+
+def compare_bank_data():
+    current_banks = dict(BANK_NAMES)
+    banxico_banks = fetch_banxico_data()
+
+    differences = {'additions': {}, 'removals': {}, 'changes': {}}
+
+    print('Comparing bank data...\n')
+
+    # Check for additions (in Banxico but not in package)
+    additions = {
+        code: name for code, name in banxico_banks.items() if code not in current_banks
+    }
+    differences['additions'] = additions
+    if additions:
+        print('=== ADDITIONS (in Banxico but not in package) ===')
+        for code, name in sorted(additions.items()):
+            print(f'  {code}: {name}')
+        print()
+
+    # Check for removals (in package but not in Banxico)
+    removals = {
+        code: name for code, name in current_banks.items() if code not in banxico_banks
+    }
+    differences['removals'] = removals
+    if removals:
+        print('=== REMOVALS (in package but not in Banxico) ===')
+        for code, name in sorted(removals.items()):
+            print(f'  {code}: {name}')
+        print()
+
+    # Check for changes (different names for the same code)
+    changes = {
+        code: (current_banks[code], banxico_banks[code])
+        for code in set(current_banks) & set(banxico_banks)
+        if current_banks[code].upper() != banxico_banks[code].upper()
+    }
+    differences['changes'] = changes
+    if changes:
+        print('=== CHANGES (different names for the same code): Package -> Banxico ===')
+        for code, (current_name, banxico_name) in sorted(changes.items()):
+            print(f'  {code}: {current_name} -> {banxico_name}')
+        print()
+
+    if not additions and not removals and not changes:
+        print('No differences found. The data is in sync.')
+
+    return differences
+
+
+if __name__ == '__main__':
+    differences = compare_bank_data()