feat: enhance configure_additional_bank with input validation

Author: gabino

clabe/validations.py

@@ -1,6 +1,8 @@
 import random
 from typing import List, Union
 
+from pydantic.errors import NotDigitError
+
 from .banks import BANK_NAMES, BANKS
 from .errors import (
     BankCodeABMAlreadyExistsError,
@@ -83,12 +85,26 @@ def configure_additional_bank(
         already exists in the provided dictionaries.
     """
 
+    if not all(
+        isinstance(x, str)
+        for x in [bank_code_abm, bank_code_banxico, bank_name]
+    ):
+        raise TypeError("All parameters must be strings")
+
+    if not bank_code_abm.isdigit():
+        raise NotDigitError
+
+    if not bank_code_banxico.isdigit():
+        raise NotDigitError
+
+    if not bank_name.strip():
+        raise ValueError("bank_name cannot be empty")
+
     if bank_code_abm in BANKS:
         raise BankCodeABMAlreadyExistsError
 
     if bank_code_banxico in BANK_NAMES:
         raise BankCodeBanxicoAlreadyExistsError
 
-    BANKS.update({bank_code_abm: bank_code_banxico})
-
-    BANK_NAMES.update({bank_code_banxico: bank_name})
+    BANKS[bank_code_abm] = bank_code_banxico
+    BANK_NAMES[bank_code_banxico] = bank_name.strip()

tests/test_clabe.py

@@ -56,3 +56,16 @@ def test_configure_additional_bank_existing_abm_code():
 def test_configure_additional_bank_existing_banxico_code():
     with pytest.raises(BankCodeBanxicoAlreadyExistsError):
         configure_additional_bank("666", "40137", "New Bank")
+
+
+def test_configure_additional_bank_invalid_inputs():
+    with pytest.raises(TypeError):
+        configure_additional_bank(3, 3, 3)
+    with pytest.raises(ValueError):
+        configure_additional_bank("A", "B", "C")
+    with pytest.raises(ValueError):
+        configure_additional_bank("666", "B", "C")
+    with pytest.raises(ValueError):
+        configure_additional_bank("777", "713", "")
+    with pytest.raises(ValueError):
+        configure_additional_bank("abc", "def", "Test Bank")