Remove CucumberReact, add CustomRendering #382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Previously we had a root component
<CucumberReact/>
which was used to set some baseline styles and give a chance to inject custom rendering overrides.We have managed to remove the need to set baseline styles, with defaults like font family and size being sensibly inherited from the parent page. So we can now replace this component with an optional
<CustomRendering/>
component just to handle that use case.For consumers this is easier - you can use any component without needing to worry about whether you've slotted in the root one high enough.
For us, with all components having encapsulated styles we have more options for styling e.g. CSS-in-JS or whatever. We can also more easily use things like modals which tend to sit at a root-level in the DOM and escape cascading styles.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.