Skip to content

Remove CucumberReact, add CustomRendering #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2025
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 4, 2025

🤔 What's changed?

Previously we had a root component <CucumberReact/> which was used to set some baseline styles and give a chance to inject custom rendering overrides.

We have managed to remove the need to set baseline styles, with defaults like font family and size being sensibly inherited from the parent page. So we can now replace this component with an optional <CustomRendering/> component just to handle that use case.

For consumers this is easier - you can use any component without needing to worry about whether you've slotted in the root one high enough.

For us, with all components having encapsulated styles we have more options for styling e.g. CSS-in-JS or whatever. We can also more easily use things like modals which tend to sit at a root-level in the DOM and escape cascading styles.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented May 4, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit 1f4bb43
🔍 Latest deploy log https://app.netlify.com/sites/cucumber-react-preview/deploys/68173677280b1d0008a6a11d
😎 Deploy Preview https://deploy-preview-382--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidjgoss davidjgoss marked this pull request as ready for review May 4, 2025 09:43
@davidjgoss davidjgoss merged commit 740c64a into main May 4, 2025
6 checks passed
@davidjgoss davidjgoss deleted the remove-root-component branch May 4, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant