Skip to content

chore: fix various issues with tooling, tests, etc #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 14, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jan 9, 2022

  • Fix tsconfig to see scss files (fixes TS Compilation error with scss running tests #6)
  • Add gherkin test data locally (until we can depend on it externally somehow)
  • Generate acceptance fixtures via node script, remove makefile (fixes Remove Make #10)
  • Remove module type hints from package.json to unconfuse storybook (fixes Can't build storybook #8)
  • Don't ignore the lockfile
  • Add tsc config to build library to dist
  • Fix some issues with status counting

@aslakhellesoy
Copy link
Contributor

I've fixed the failing tests, but they still seem to be hanging. I don't know what tests are hanging yet.

@davidjgoss
Copy link
Contributor Author

Weird one. From the run output it looks like all the tests finish, but something maybe not cleaned up from one of them. I'll take another look today.

@davidjgoss davidjgoss marked this pull request as ready for review January 14, 2022 18:11
@davidjgoss
Copy link
Contributor Author

Okay this gets us to a workable project, just needs the release workflows adding. I'll raise a separate issue to find the root cause of the leaky test, in the meantime adding exit: true in the mocha config is enough to force it.

@davidjgoss davidjgoss merged commit cb312cf into main Jan 14, 2022
@davidjgoss davidjgoss deleted the fix/project-issues branch January 14, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Make Can't build storybook TS Compilation error with scss running tests
2 participants