Skip to content

Commit

Permalink
refactor: Remove redundant gems (#1743)
Browse files Browse the repository at this point in the history
* No verbose requirements for syntax or test-unit as gems

* Update of dependent gems

* Update changelog

* Removed sinatra example as it was extremely straw-man and it should be tested elsewhere

* Removed rack-test dependency as it was required through capybara which is no longer required

* Permit next major of messages coming out soon

* Update readme for i18n examples
  • Loading branch information
luke-hill authored Dec 8, 2023
1 parent 2a9da4b commit 32f0694
Show file tree
Hide file tree
Showing 12 changed files with 23 additions and 119 deletions.
10 changes: 8 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) for more info on how to contribute to Cucumber.

## [Unreleased]

## [9.1.0] - 2023-11-14
### Added

### Changed
- Updated dependencies to slightly more permissive / up to date versions ([luke-hill](https://github.com/luke-hill))

### Fixed

### Removed

## [9.1.0] - 2023-11-14
### Changed
- First couple of passes of tidying up approximately 40% of the manual fix cops
([#1739](https://github.com/cucumber/cucumber-ruby/pull/1739) [#1740](https://github.com/cucumber/cucumber-ruby/pull/1740) [#1741](https://github.com/cucumber/cucumber-ruby/pull/1741) [#1742](https://github.com/cucumber/cucumber-ruby/pull/1742) [luke-hill](https://github.com/luke-hill))
Expand Down
34 changes: 11 additions & 23 deletions cucumber.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,40 +26,28 @@ Gem::Specification.new do |s|
s.add_dependency 'cucumber-ci-environment', '~> 9.2', '>= 9.2.0'
s.add_dependency 'cucumber-core', '~> 12.0'
s.add_dependency 'cucumber-cucumber-expressions', '~> 17.0'
s.add_dependency 'cucumber-gherkin', '>= 24', '< 27'
s.add_dependency 'cucumber-html-formatter', '~> 20.4', '>= 20.4.0'
s.add_dependency 'cucumber-messages', '>= 19', '< 23'
s.add_dependency 'diff-lcs', '~> 1.5', '>= 1.5.0'
s.add_dependency 'cucumber-gherkin', '> 24', '< 27'
s.add_dependency 'cucumber-html-formatter', '> 20.3', '< 22'
s.add_dependency 'cucumber-messages', '> 19', '< 25'
s.add_dependency 'diff-lcs', '~> 1.5'
s.add_dependency 'mini_mime', '~> 1.1', '>= 1.1.5'
s.add_dependency 'multi_test', '~> 1.1', '>= 1.1.0'
s.add_dependency 'sys-uname', '~> 1.2', '>= 1.2.3'

s.add_development_dependency 'cucumber-compatibility-kit', '~> 14.0'
s.add_development_dependency 'cucumber-compatibility-kit', '~> 14.1'
# Only needed whilst we are testing the formatters. Can be removed once we remove tests for those
s.add_development_dependency 'nokogiri', '~> 1.13', '>= 1.13.6'
s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
s.add_development_dependency 'rspec', '~> 3.12', '>= 3.12.0'
s.add_development_dependency 'nokogiri', '~> 1.14'
s.add_development_dependency 'rake', '~> 13.1'
s.add_development_dependency 'rspec', '~> 3.12'
s.add_development_dependency 'rubocop', '~> 1.56.4'
s.add_development_dependency 'rubocop-capybara', '~> 2.19.0'
s.add_development_dependency 'rubocop-packaging', '~> 0.5.2'
s.add_development_dependency 'rubocop-rake', '~> 0.6.0'
s.add_development_dependency 'rubocop-rspec', '~> 2.24.1'
s.add_development_dependency 'rubocop-rspec', '~> 2.25.0'
s.add_development_dependency 'simplecov', '~> 0.22.0'
s.add_development_dependency 'syntax', '~> 1.2', '>= 1.2.2'
s.add_development_dependency 'test-unit', '~> 3.6', '>= 3.6.1'
s.add_development_dependency 'webrick', '~> 1.8', '>= 1.8.1'
s.add_development_dependency 'webrick', '~> 1.8'

# Needed for rake examples
s.add_development_dependency 'capybara', '~> 3.39', '>= 3.39.2'
s.add_development_dependency 'rack-test', '~> 2.1', '>= 2.1.0'
s.add_development_dependency 'sinatra', '~> 3.1', '>= 3.1.0'

s.files = Dir[
'README.md',
'LICENSE',
'VERSION',
'lib/**/*'
]
s.files = Dir['README.md', 'LICENSE', 'VERSION', 'lib/**/*']
s.executables = ['cucumber']
s.rdoc_options = ['--charset=UTF-8']
s.require_path = 'lib'
Expand Down
4 changes: 4 additions & 0 deletions examples/i18n/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Internationalisation (i18n) examples

Visit the [languages](https://cucumber.io/docs/gherkin/languages/) page for instructions on how to use Cucumber
in different languages - over 70 are currently supported.
3 changes: 0 additions & 3 deletions examples/i18n/README.textile

This file was deleted.

13 changes: 0 additions & 13 deletions examples/sinatra/README.textile

This file was deleted.

8 changes: 0 additions & 8 deletions examples/sinatra/Rakefile

This file was deleted.

16 changes: 0 additions & 16 deletions examples/sinatra/app.rb

This file was deleted.

11 changes: 0 additions & 11 deletions examples/sinatra/features/add.feature

This file was deleted.

17 changes: 0 additions & 17 deletions examples/sinatra/features/step_definitions/add_steps.rb

This file was deleted.

11 changes: 0 additions & 11 deletions examples/sinatra/features/support/env.rb

This file was deleted.

7 changes: 0 additions & 7 deletions examples/sinatra/views/add.erb

This file was deleted.

8 changes: 0 additions & 8 deletions examples/sinatra/views/layout.erb

This file was deleted.

0 comments on commit 32f0694

Please sign in to comment.