Skip to content

ensure user locale does not make DefaultSummaryPrinterTest failling #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rmannibucau
Copy link
Contributor

I'm in french locale by default so decimal separator is "," and not "." so DefaultSummaryPrinterTest fails because 0.00 != 0,00 whereas the test actually functionally worked.

this pr enforces the locale for the test to ensure the assert will pass.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.956% when pulling dac615e on rmannibucau:rmannibucau/fix-DefaultSummaryPrinterTest-for-not-en-locales into 1796209 on cucumber:master.

@mpkorstanje
Copy link
Contributor

Ah thanks! This doesn't fix the root cause. I'll have a stab at it, there are some other complexities surrounding this.

@rmannibucau
Copy link
Contributor Author

@mpkorstanje root cause is there

;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants