Receive Scenario in hooks

[aslakhellesoy]

This is important in order to take screenshots etc, as it allows to inspect whether or not a scenario has failed.

[mattwynne]

On 30 Aug 2011, at 16:54, aslakhellesoy wrote:

This is important in order to take screenshots etc, as it allows to inspect whether or not a scenario has failed.

My view on a problem in the cucumber 1.0 codebase is that the scenario object (which IMO should be a simple value object) becomes dirtied with state when it also contains the result. That makes the object overcomplex, and is a big factor in the general overcomplexity of that AST design.

IMO it would keep things cleaner to either have the After block receive a ScenarioResult object that has a reference to the scenario, or two objects, a Scenario and a ScenarioResult.

Just my 2 cents.

[aslakhellesoy]

Good observation. I think maybe we should pass a Result instead:

https://github.com/cucumber/gherkin/blob/master/lib/gherkin/formatter/model.rb#L221
https://github.com/cucumber/gherkin/blob/master/java/src/main/java/gherkin/formatter/model/Result.java

Currently a Result is associated with a Step, but it shouldn't be problematic to create one for a Scenario as well.

[mattwynne]

On 31 Aug 2011, at 11:22, aslakhellesoy wrote:

Good observation. I think maybe we should pass a Result instead:

https://github.com/cucumber/gherkin/blob/master/lib/gherkin/formatter/model.rb#L221
https://github.com/cucumber/gherkin/blob/master/java/src/main/java/gherkin/formatter/model/Result.java

Currently a Result is associated with a Step, but it shouldn't be problematic to create one for a Scenario as well.

How about we make a ScenarioResult that's got an array of (Step)Results? I might be interesting to see whether steps have been skipped / undefined etc. as well as the overall result of the scenario.

cheers,
Matt

Freelance programmer & coach
Author, http://pragprog.com/book/hwcuc/the-cucumber-book (with Aslak Hellesøy)
Founder, http://relishapp.com
+44(0)7974430184 | http://twitter.com/mattwynne

[aslakhellesoy]

I like that idea

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.