Skip to content

Commit 5759eb8

Browse files
authored
Remove Jackson services from META-INF (#2621)
Like everyone else Cucumber needs to write Json and does so using Jackson. To avoid conflicts with other versions of Jackson, Cucumber shades its own version. Unfortunately this shading isn't done perfectly and the files in `META-INF/services` are not updated to match. By excluding the services declared by Jackson we can avoid this problem altogether, though it may come back in the future if/when Jackson decides to use its own services outside of `ObjectMapper.findAndRegisterModules`. Hopefully, the shade plugin has been fixed by then. Fixes: #2620
1 parent 39358be commit 5759eb8

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

CHANGELOG.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,17 @@ explanation of noteworthy changes see the [Release Announcement](release-notes/v
99
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
1010
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
1111

12-
[Core] Omit filtered out pickles from html report ([react-components/#273](https://github.com/cucumber/react-components/pull/273) David J. Goss)
13-
1412
## [Unreleased]
13+
## Fixed
14+
- [Core] Remove Jackson services from `META-INF/services` ([#2621](https://github.com/cucumber/cucumber-jvm/issues/2607) M.P. Korstanje)
15+
- [JUnit Platform] Use JUnit Platform 1.9.1 (JUnit Jupiter 5.9.1)
1516

1617
## [7.8.0] - 2022-09-15
1718
### Added
1819
- [Core] Support comparison of expected and actual values in IntelliJ IDEA ([#2607](https://github.com/cucumber/cucumber-jvm/issues/2607) Andrey Vokin)
20+
- [Core] Omit filtered out pickles from html report ([react-components/#273](https://github.com/cucumber/react-components/pull/273) David J. Goss)
1921
- [Datatable] Support parsing Booleans in Datatables ([#2614](https://github.com/cucumber/cucumber-jvm/pull/2614) G. Jourdan-Weil)
20-
-
21-
22+
2223
## [7.7.0] - 2022-09-08
2324
### Added
2425
- [JUnit Platform] Enable parallel execution of features ([#2604](https://github.com/cucumber/cucumber-jvm/pull/2604) Sambathkumar Sekar)

cucumber-core/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,10 +246,12 @@
246246
<filter>
247247
<artifact>com.fasterxml.jackson.core:jackson-databind</artifact>
248248
<excludes>
249+
<exclude>**/module-info.class</exclude>
249250
<exclude>**/module-info.class</exclude>
250251
<exclude>META-INF/MANIFEST.MF</exclude>
251252
<exclude>META-INF/LICENSE</exclude>
252253
<exclude>META-INF/NOTICE</exclude>
254+
<exclude>META-INF/services/**</exclude>
253255
</excludes>
254256
</filter>
255257
<filter>
@@ -259,6 +261,7 @@
259261
<exclude>META-INF/MANIFEST.MF</exclude>
260262
<exclude>META-INF/LICENSE</exclude>
261263
<exclude>META-INF/NOTICE</exclude>
264+
<exclude>META-INF/services/**</exclude>
262265
</excludes>
263266
</filter>
264267
<filter>
@@ -275,6 +278,7 @@
275278
<exclude>**/module-info.class</exclude>
276279
<exclude>META-INF/MANIFEST.MF</exclude>
277280
<exclude>META-INF/LICENSE</exclude>
281+
<exclude>META-INF/services/**</exclude>
278282
</excludes>
279283
</filter>
280284
</filters>

0 commit comments

Comments
 (0)