Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve absolute path warnings #691

Closed
mvz opened this issue Jan 2, 2020 · 0 comments · Fixed by #783
Closed

Improve absolute path warnings #691

mvz opened this issue Jan 2, 2020 · 0 comments · Fixed by #783
Milestone

Comments

@mvz
Copy link
Contributor

mvz commented Jan 2, 2020

Summary

Aruba warns when its API methods are called with an absolute path, but this warning is not very informative.

Expected Behavior

When the user calls an Aruba API method with an absolute path, Aruba reports the file and line of the user code or cucumber step, so the user can fix it.

Current Behavior

Aruba complains about expand_path being called, even if that happens through several steps inside Aruba's implementation.

Steps to Reproduce (for bugs)

See https://github.com/colszowka/simplecov/blob/master/features/config_coverage_dir.feature#L22-L33 for an example of a scenario using an absolute file name.

Context & Motivation

See #687 (comment).

@mvz mvz mentioned this issue Jan 2, 2020
8 tasks
@mvz mvz added this to the 1.1.0 milestone Jan 2, 2020
@mvz mvz modified the milestones: 1.1.0, 1.2.0 Aug 21, 2020
@mvz mvz modified the milestones: 1.1.0, 2.0.0 Jun 20, 2021
@mvz mvz closed this as completed in #783 Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant