Skip to content
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.

Implement hooks #29

Open
jowers opened this issue Jun 1, 2015 · 3 comments
Open

Implement hooks #29

jowers opened this issue Jun 1, 2015 · 3 comments

Comments

@jowers
Copy link
Contributor

jowers commented Jun 1, 2015

Currently, as each scenario is a new tcl interpreter, we have been using inline tcl to perform setup tasks for our tests. However, as there is no order to the files being sourced, we have hit a few problems with dependencies (e.g. trying to call a proc before it has been initialised).

It would be good if we were able to have before/after hooks to allow us to perform the initialisation in the before hook, knowing that everything has been sourced by that point.

@mattwynne, would this require changes to cucumber to allow hooks to be passed through?

Note - we'd need to consider what scope things are being run in if looking at this.

@mattwynne
Copy link
Contributor

Hi @jowers.

I think we can do this without any changes to Cucumber. Shall we start with a feature file as usual, where you can sketch out the tcl DSL for defining hooks, and we can work our way in from there?

@jowers
Copy link
Contributor Author

jowers commented Jun 2, 2015

Hi,

Sounds good. I'm actually going to have a go at issue #28 first as it should be a quick one that is causing a little bit of frustration at the moment, then I'll move onto this one.

@jowers
Copy link
Contributor Author

jowers commented Jun 8, 2015

Created pull request #33

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants