Fix 1151 element named none #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cubewise-JoeCHK
force-pushed
the
fix-1151-element-named-None
branch
from
2a0e00a to
c528fbf
Compare
Fix error of transforming None element name to np.nan
MariusWirtz
force-pushed
the
fix-1151-element-named-None
branch
from
c528fbf to
844f41c
Compare
Collaborator
|
@Cubewise-JoeCHK I force-pushed a small change to this branch. Can you please review and approve? |
Contributor
Author
|
@MariusWirtz Looks good to me... |
Contributor
|
Tests completed for environment: tm1-11-cloud. Check artifacts for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the functionality of replacing na_values with ['', None]
not very sure "Value" column
ran test:
pytest -k "execute_mdx_dataframe or execute_view_dataframe or extract_cellset_dataframe or build_dataframe_from_csv"close #1151