Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cubed Array vs cubed.CoreArray #123

Closed
TomNicholas opened this issue Sep 10, 2022 · 1 comment · Fixed by #124
Closed

cubed Array vs cubed.CoreArray #123

TomNicholas opened this issue Sep 10, 2022 · 1 comment · Fixed by #124

Comments

@TomNicholas
Copy link
Member

Hi, I'm just a bit confused by what the difference is between the Array object defined in cubed.array_api.array_object and the cubed.CoreArray that is returned by cubed.from_array and asarray. CoreArray doesn't implement the numpy API, but Array isn't importable from cubed's top-level namespace.

Is this deliberate or should things be changed so that the only type a user sees is Array?
@tomwhite
Copy link
Member

This does seem wrong - thanks for raising it.

Is this deliberate or should things be changed so that the only type a user sees is Array?

Yes. Array should be the type in the the top-level namespace and the user-facing documentation. CoreArray is an internal implementation detail.

This was referenced Sep 11, 2022
Merged
Merged
@TomNicholas TomNicholas mentioned this issue Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose Array not CoreArray TomNicholas/cubed
2 participants
@tomwhite @TomNicholas