Skip to content

Commit 9a72c42

Browse files
committed
Code polish
1 parent b694196 commit 9a72c42

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/cubejs-playground/src/QueryBuilderV2/components/ChartRenderer.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,10 @@ function CartesianChart({
122122
let granularity = granularityField?.split('.')[2];
123123

124124
if (!isPredefinedGranularity(granularity)) {
125-
const granularityInfo = resultSet?.loadResponse.results[0].annotation.timeDimensions[granularityField]?.granularity;
126-
granularity = minGranularityForIntervals(granularityInfo.interval, granularityInfo.offset || granularityFor(granularityInfo.origin));
125+
const granularityInfo = resultSet?.loadResponse.results[0]?.annotation.timeDimensions[granularityField]?.granularity;
126+
if (granularityInfo) {
127+
granularity = minGranularityForIntervals(granularityInfo.interval, granularityInfo.offset || granularityFor(granularityInfo.origin));
128+
}
127129
}
128130

129131
const formatDate = useMemo(() => {

packages/cubejs-playground/src/QueryBuilderV2/components/TimeListMember.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@ export function TimeListMember(props: ListMemberProps) {
7070

7171
const customGranularities = (member.type === 'time' && member.granularities) ?
7272
member.granularities.map(g => g.name) : [];
73-
const memberGranularities = (member.type === 'time' && member.granularities) ?
74-
member.granularities.map(g => g.name).concat(PREDEFINED_GRANULARITIES) :
75-
PREDEFINED_GRANULARITIES;
73+
const memberGranularities = customGranularities.concat(PREDEFINED_GRANULARITIES);
7674
const isGranularitySelectedMap = {};
7775
memberGranularities.forEach((granularity) => {
7876
isGranularitySelectedMap[granularity] = isSelected(granularity)

0 commit comments

Comments
 (0)