Efficientnet lite #141
Merged
Efficientnet lite #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psyhtest
reviewed
Jul 31, 2020
| # SPDX-License-Identifier: BSD-3-Clause. | ||
| # See CK LICENSE.txt for licensing details. | ||
| # | ||
| # MobileNet for TensorFlow |
There was a problem hiding this comment.
MobileNet -> EfficientNet
psyhtest
reviewed
Jul 31, 2020
|
|
||
| echo "Keeping file ${PACKAGE_NAME_EFFICIENTNET_LITE_WITH_PRECISION}.tflite" | ||
|
|
||
| if [ "${MODEL_EFFICIENTNET_LITE_PRECISION}" == "fp32" ]; then |
There was a problem hiding this comment.
Please move common code out of the branches:
if [ "${MODEL_EFFICIENTNET_LITE_PRECISION}" == "fp32" ]; then
file_to_remove="${PACKAGE_NAME_EFFICIENTNET_LITE}-int8.tflite"
else
file_to_remove="${PACKAGE_NAME_EFFICIENTNET_LITE}-fp32.tflite"
fi
echo "Removing file ${file_to_remove}"
rm ${file_to_remove}
psyhtest
reviewed
Jul 31, 2020
| echo "Removing file ${file_to_remove}" | ||
| rm ${file_to_remove} | ||
| fi | ||
|
|
There was a problem hiding this comment.
Please remove empty lines.
psyhtest
reviewed
Jul 31, 2020
| echo | ||
| echo "Remove temporary files ..." | ||
| rm ${PACKAGE_NAME} | ||
|
|
There was a problem hiding this comment.
Please remove everything below this line.
psyhtest
reviewed
Jul 31, 2020
| tar -zxvf ${PACKAGE_NAME} | ||
|
|
||
|
|
||
| #Efficientnet-lite unpacks into subdirectory |
psyhtest
reviewed
Jul 31, 2020
|
|
||
|
|
||
| #Efficientnet-lite unpacks into subdirectory | ||
| if [[ -d ${PACKAGE_NAME_EFFICIENTNET_LITE} ]]; then |
There was a problem hiding this comment.
Don't strictly need this if as only dealing with EfficientNet in this script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Efficientnet-lite related commits for ck-tensorflow